Skip to content

Use AccountPtr in Account signals instead of raw pointer #5543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
claucambra merged 7 commits into from
Apr 15, 2025
Merged

Use AccountPtr in Account signals instead of raw pointer #5543

claucambra merged 7 commits into from
Apr 15, 2025

Conversation

@claucambra
Copy link
Contributor

@claucambra claucambra commented Mar 22, 2023

No description provided.

@claucambra claucambra self-assigned this Mar 22, 2023
@claucambra claucambra force-pushed the bugfix/signal-account-ptr branch from 5f71219 to 5a3752d Compare March 22, 2023 14:32
@claucambra claucambra mentioned this pull request Mar 22, 2023
Merged
mgallien
mgallien requested changes Mar 23, 2023
View reviewed changes
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TestPushNotifications test is failing for me
can you investigate ?

@claucambra
Copy link
Contributor Author

claucambra commented Mar 23, 2023

TestPushNotifications test is failing for me
can you investigate ?

Now fixed

@claucambra claucambra requested a review from mgallien March 23, 2023 16:48
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 23, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

26.1% 26.1% Coverage
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #5543 (6146f02) into master (54a11e8) will decrease coverage by 0.08%.
The diff coverage is 14.28%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5543      +/-   ##
==========================================
- Coverage   58.96%   58.88%   -0.08%     
==========================================
  Files         143      143              
  Lines       18314    18332      +18     
==========================================
- Hits        10798    10795       -3     
- Misses       7516     7537      +21
Impacted Files Coverage Δ
src/libsync/account.h 36.84% <ø> (ø)
src/libsync/creds/httpcredentials.cpp 6.87% <0.00%> (-0.02%) ⬇️
src/libsync/account.cpp 35.85% <16.66%> (ø)

... and 5 files with indirect coverage changes

@claucambra claucambra added this to the 3.13.1 milestone Jun 9, 2024
@mgallien mgallien modified the milestones: 3.13.1, 3.13.2 Jul 2, 2024
@camilasan camilasan modified the milestones: 3.13.2, 3.13.3 Jul 9, 2024
@mgallien mgallien modified the milestones: 3.13.3, 3.14.0 Aug 23, 2024
@claucambra claucambra modified the milestones: 3.14.0, 3.14.2 Oct 11, 2024
@claucambra claucambra force-pushed the bugfix/signal-account-ptr branch 2 times, most recently from 86709cb to b88a6f5 Compare October 18, 2024 06:25
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 18, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
23.1% Coverage on New Code (required ≥ 80%)
61 New Code Smells (required ≤ 0)
D Maintainability Rating on New Code (required ≥ A)
D Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@Rello Rello modified the milestones: 3.14.2, 3.14.3 Oct 18, 2024
@claucambra claucambra modified the milestones: 3.14.4, 3.14.5 Nov 3, 2024
@Rello Rello modified the milestones: 3.14.5, 3.15.0 Nov 11, 2024
@claucambra claucambra force-pushed the bugfix/signal-account-ptr branch from b88a6f5 to 7bdd453 Compare November 20, 2024 07:13
@nextcloud-desktop-bot
Copy link

nextcloud-desktop-bot commented Nov 20, 2024

AppImage file: nextcloud-PR-5543-7bdd45314d7c866bee49e0f5969afe926d7eb0d7-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 20, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
23.1% Coverage on New Code (required ≥ 80%)
D Security Rating on New Code (required ≥ A)
76 New Code Smells (required ≤ 0)
E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@Rello Rello modified the milestones: 3.15.0, 3.16.0 Nov 22, 2024
@claucambra claucambra modified the milestones: 3.16.0, 3.16.1 Feb 5, 2025
@mgallien mgallien modified the milestones: 3.16.1, 3.16.2, 3.16.3 Mar 12, 2025
@claucambra claucambra force-pushed the bugfix/signal-account-ptr branch from 7bdd453 to 8a2861e Compare April 15, 2025 07:59
@claucambra claucambra requested a review from nilsding as a code owner April 15, 2025 07:59
@claucambra
Use AccountPtr in pushNotificationsReady signal in Account rather tha…
a2e3d63 
…n raw pointer

Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Emit AccountPtr from pushNotificationsDisabled in Account rather than…
d3f3b05 
… raw pointer

Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Replace use of raw pointer in wantsAccountSaved signal with AccountPtr
78b8f07 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Use AccountPtr in serverVersionChanged signal instead of raw pointer
49bac25 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Use AccountPtr in testpushnotifications
b2836dd 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Fix use of saveAccount in networksettings
d6f4fa2 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
fix(gui): Use AccountPtr in setup wizard
1e5bf2f 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra claucambra force-pushed the bugfix/signal-account-ptr branch from 38ecc1b to 1e5bf2f Compare April 15, 2025 09:08
@claucambra claucambra merged commit 537fc38 into master Apr 15, 2025
13 of 15 checks passed
@claucambra claucambra deleted the bugfix/signal-account-ptr branch April 15, 2025 09:08
@claucambra
Copy link
Contributor Author

claucambra commented Apr 15, 2025

/backport to stable-3.16

@backportbot backportbot bot mentioned this pull request Apr 15, 2025
Merged
@github-actions
Copy link

github-actions bot commented Apr 15, 2025

Artifact containing the AppImage: nextcloud-appimage-pr-5543.zip

SHA256 checksum: dac9c3fa385b12410fb663fe1adcc86a0b3ca66e7dbe453e202c986067498f7f

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 15, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@nilsding nilsding modified the milestones: 3.16.3, 3.17.0 Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camilasan camilasan Awaiting requested review from camilasan camilasan is a code owner

@allexzander allexzander Awaiting requested review from allexzander

@mgallien mgallien Awaiting requested review from mgallien mgallien is a code owner

@nilsding nilsding Awaiting requested review from nilsding nilsding is a code owner

Assignees

@claucambra claucambra

Labels

None yet

Projects

None yet

Milestone

3.17.0

Development

Successfully merging this pull request may close these issues.

7 participants

@claucambra @nextcloud-desktop-bot @mgallien @camilasan @nilsding @Rello