fix(theme): correct dark/light mode check on Win10 #8156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsding
requested review from
camilasan,
claucambra and
mgallien
as code owners
Member
Author
|
/backport to stable-3.16 |
nilsding
added
os: 🚪 Windows
feature: ☁️ GUI
claucambra
approved these changes
Apr 15, 2025
`Utility::registryGetKeyValue` returns an invalid QVariant should the key not exist -- which is the case if that switch has never been toggled before. --> Fix this by ensuring the QVariant is valid, and only then try to convert it to a bool. Signed-off-by: Jyrki Gadinger <[email protected]>
nilsding
force-pushed
the
bugfix/win10-darkmode-strikes-back
branch
from
ca53dd5 to
2a3b5be
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-8156.zip SHA256 checksum: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Utility::registryGetKeyValuereturns an invalid QVariant should the key not exist -- which is the case if that switch has never been toggled before.--> Fix this by ensuring the QVariant is valid, and only then try to convert it to a bool.
Tested on Windows Server 2019, which is close enough to Win10 I think.