feat: support notify_file_id push notifications
#8502
Conversation
nilsding
force-pushed
the
feature/notify-file-ids
branch
from
a44cead to
a2a4ae9
Compare
nilsding
force-pushed
the
feature/notify-file-ids
branch
from
a2a4ae9 to
5eb8f40
Compare
|
nilsding
force-pushed
the
feature/notify-file-ids
branch
5 times, most recently
from
0416656 to
e44e080
Compare
nilsding
changed the title
notify_file_id push notificationsnotify_file_id push notifications
nilsding
force-pushed
the
feature/notify-file-ids
branch
from
e44e080 to
c110120
Compare
nilsding
force-pushed
the
feature/notify-file-ids
branch
from
c110120 to
6b509d1
Compare
mgallien
left a comment
mgallien
left a comment
There was a problem hiding this comment.
thanks
some small comments
nilsding
force-pushed
the
feature/notify-file-ids
branch
from
6b509d1 to
025a73c
Compare
For this to work we also now need to store the fileId from the sync root folder, otherwise we would never know about new files inside the configured sync root Signed-off-by: Jyrki Gadinger <[email protected]>
Signed-off-by: Jyrki Gadinger <[email protected]>
Signed-off-by: Jyrki Gadinger <[email protected]>
Signed-off-by: Jyrki Gadinger <[email protected]>
…ponses - `oc:id` is the file ID + the instance ID - `oc:fileid` is the file ID on its own Signed-off-by: Jyrki Gadinger <[email protected]>
Signed-off-by: Jyrki Gadinger <[email protected]>
Signed-off-by: Jyrki Gadinger <[email protected]>
Signed-off-by: Jyrki Gadinger <[email protected]>
`.isDouble` becomes more clear if one can immediately tell this is operating on a JSON type Signed-off-by: Jyrki Gadinger <[email protected]>
mgallien
force-pushed
the
feature/notify-file-ids
branch
from
025a73c to
5667ea2
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-8502.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
github-project-automation
bot
moved this from 🏗️ In progress
to ☑️ Done
in 💻 Desktop Clients team
|
only basic support for now: schedule a folder to sync if any of the received
fileids is known.This has no effect on the macOS File Provider implementation as it uses its own web socket connection. I would prefer to work on this after #9176 was merged.