Skip to content

[stable-4.0] refactor: Use correct string overload #9231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
camilasan merged 1 commit into from
Dec 11, 2025

refactor: Use correct string overload

428e46e
Select commit
Loading
Failed to load commit list.
Merged

[stable-4.0] refactor: Use correct string overload #9231

refactor: Use correct string overload
428e46e
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Dec 11, 2025 in 35m 35s

Quality Gate failed

Failed conditions
59.4% Coverage on New Code (required ≥ 80%)
31 New Code Smells (required ≤ 0)
E Reliability Rating on New Code (required ≥ A)
1 New Bugs (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 402 in src/gui/sharemanager.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the init-statement to declare "data" inside the if statement. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZsNNN0k9vL1_wjGWSYP&open=AZsNNN0k9vL1_wjGWSYP&pullRequest=9231

Check failure on line 467 in src/gui/sharemanager.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly capture all local variables required in this lambda. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZsNNN0k9vL1_wjGWSYR&open=AZsNNN0k9vL1_wjGWSYR&pullRequest=9231

Check warning on line 124 in src/gui/userinfo.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

implicit conversion turns floating-point number into integer: 'double' to 'qint64' (aka 'long long') 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZsNNN2I9vL1_wjGWSYa&open=AZsNNN2I9vL1_wjGWSYa&pullRequest=9231

Check warning on line 158 in src/libsync/ocsuserstatusconnector.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the init-statement to declare "typeValue" inside the if statement. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZsNNN6D9vL1_wjGWSYo&open=AZsNNN6D9vL1_wjGWSYo&pullRequest=9231

Check warning on line 571 in src/gui/sharemanager.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "shareType" of type "int" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZsNNN0k9vL1_wjGWSYT&open=AZsNNN0k9vL1_wjGWSYT&pullRequest=9231

Check warning on line 712 in src/gui/socketapi/socketapi.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "url" of type "class QUrl" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZsNNN1x9vL1_wjGWSYY&open=AZsNNN1x9vL1_wjGWSYY&pullRequest=9231

Check warning on line 606 in src/gui/sharemanager.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "sharee" of type "class QSharedPointer<class OCC::Sharee>" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZsNNN0k9vL1_wjGWSYU&open=AZsNNN0k9vL1_wjGWSYU&pullRequest=9231

Check warning on line 698 in src/libsync/discoveryphase.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace with the version of "std::ranges::transform" that takes a range. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZsNNN229vL1_wjGWSYl&open=AZsNNN229vL1_wjGWSYl&pullRequest=9231

Check warning on line 541 in src/libsync/discoveryphase.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "slash" of type "int" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZsNNN229vL1_wjGWSYj&open=AZsNNN229vL1_wjGWSYj&pullRequest=9231

Check warning on line 711 in src/gui/socketapi/socketapi.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "data" of type "class QJsonObject" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZsNNN1x9vL1_wjGWSYX&open=AZsNNN1x9vL1_wjGWSYX&pullRequest=9231

Check warning on line 123 in src/gui/userinfo.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

implicit conversion turns floating-point number into integer: 'double' to 'qint64' (aka 'long long') 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZsNNN2I9vL1_wjGWSYZ&open=AZsNNN2I9vL1_wjGWSYZ&pullRequest=9231

Check warning on line 447 in src/gui/owncloudsetupwizard.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "expectedPath" of type "class QString" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZsNNN1P9vL1_wjGWSYW&open=AZsNNN1P9vL1_wjGWSYW&pullRequest=9231

Check warning on line 541 in src/libsync/discoveryphase.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

implicit conversion loses integer precision: 'qsizetype' (aka 'long long') to 'int' 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZsNNN229vL1_wjGWSYi&open=AZsNNN229vL1_wjGWSYi&pullRequest=9231

Check warning on line 305 in src/gui/sharemanager.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the init-statement to declare "data" inside the if statement. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZsNNN0k9vL1_wjGWSYN&open=AZsNNN0k9vL1_wjGWSYN&pullRequest=9231

Check warning on line 594 in src/gui/tray/unifiedsearchresultslistmodel.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this declaration by a structured binding declaration. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZsNNNzi9vL1_wjGWSYM&open=AZsNNNzi9vL1_wjGWSYM&pullRequest=9231

Check failure on line 155 in src/gui/tray/notificationhandler.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZsNNNxp9vL1_wjGWSYJ&open=AZsNNNxp9vL1_wjGWSYJ&pullRequest=9231

Check warning on line 124 in src/gui/userinfo.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "total" of type "long long" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZsNNN2I9vL1_wjGWSYf&open=AZsNNN2I9vL1_wjGWSYf&pullRequest=9231

Check failure on line 379 in src/libsync/networkjobs.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 67 to the 25 allowed. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZsNNN379vL1_wjGWSYn&open=AZsNNN379vL1_wjGWSYn&pullRequest=9231

Check warning on line 644 in src/gui/accountstate.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "app" of type "class OCC::AccountApp *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZsNNN2e9vL1_wjGWSYg&open=AZsNNN2e9vL1_wjGWSYg&pullRequest=9231

Check failure on line 643 in src/gui/accountstate.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the use of "new" with an operation that automatically manages the memory. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZsNNN2e9vL1_wjGWSYh&open=AZsNNN2e9vL1_wjGWSYh&pullRequest=9231

Check warning on line 396 in src/gui/sharemanager.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "data" of type "class QJsonObject" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZsNNN0k9vL1_wjGWSYQ&open=AZsNNN0k9vL1_wjGWSYQ&pullRequest=9231

Check warning on line 680 in src/gui/sharemanager.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "sharee" of type "class QSharedPointer<class OCC::Sharee>" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZsNNN0k9vL1_wjGWSYV&open=AZsNNN0k9vL1_wjGWSYV&pullRequest=9231

Check warning on line 117 in src/gui/userinfo.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "displayName" of type "class QString" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZsNNN2I9vL1_wjGWSYc&open=AZsNNN2I9vL1_wjGWSYc&pullRequest=9231

Check warning on line 101 in src/gui/userinfo.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "objData" of type "class QJsonObject" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZsNNN2I9vL1_wjGWSYb&open=AZsNNN2I9vL1_wjGWSYb&pullRequest=9231

Check failure on line 703 in src/libsync/discoveryphase.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Potential leak of memory pointed to by 'e2EeFolderMetadata' 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZsNNN229vL1_wjGWSYm&open=AZsNNN229vL1_wjGWSYm&pullRequest=9231
View more details on SonarQubeCloud