Implement support for insertion of multimedia from Nextcloud assets #4249
Conversation
mikekaganski
force-pushed
the
private/mk/insertRemoteMultimedia
branch
2 times, most recently
from
2a5b630 to
5e4da27
Compare
This change adds ability to insert multimedia files from Nextcloud to Impress documents. It advertises EnableInsertRemoteFile capability, so that Office activates the feature (depends on Office including commit 60d9a9c20bf69b3f1d8591b2d8400c4a453970ab - older builds won't show the respective button). Signed-off-by: Mike Kaganski <[email protected]>
mikekaganski
force-pushed
the
private/mk/insertRemoteMultimedia
branch
from
5e4da27 to
68ebfaa
Compare
elzody
added
enhancement
|
i think i understand the change here, but as i'm trying to test it out, i can't tell how i'm actually supposed to use it. the forgive me if i'm oblivious :) |
|
@elzody thanks for testing! But I obviously missed the "master branch of collabora online server from today, 19.11" part yesterday, when I read that (it was already 1 AM here locally :-) ), sorry for that. The insertion should look like this:
|
elzody
left a comment
elzody
left a comment
There was a problem hiding this comment.
Thank you for the animation -- it was helpful in clarifying things! :) I managed to test it and it seems to work just fine. The code changes look decent to me. Thanks for contributing to this!
|
@elzody Would this be safe to port into stable30 branch? |
|
@thebearon It probably would be fine to, I can go ahead and trigger one and we can give it some testing just to make sure it works fine, but it looks like it would. |
|
/backport to stable30 |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
3 participants
This change adds ability to insert multimedia files from Nextcloud to Impress
documents. It advertises EnableInsertRemoteFile capability, so that Office
activates the feature (requires Office including commit 60d9a9c20bf69b3f1d8591b2d8400c4a453970ab;
older builds won't show the respective button).