Skip to content

Fix errors when extracting content controls #4253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
juliusknorr merged 2 commits into from
Nov 25, 2024
Merged

Fix errors when extracting content controls #4253

juliusknorr merged 2 commits into from
Nov 25, 2024

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Nov 22, 2024 •
edited
Loading

  • fix: properly filter for content controls
    • This commit fixes the filtering that has been in place but was likely not working anymore due to an upstream change
  • fix: Catch unexpected results with no type
    • Safeguard the results to not fail hard on unexpected result sets

Fix #4228

@juliusknorr juliusknorr requested a review from elzody as a code owner November 22, 2024 14:03
@juliusknorr juliusknorr added bug Something isn't working 3. to review Ready to be reviewed labels Nov 22, 2024
@juliusknorr juliusknorr changed the title fix/transform Fix errors when extracting content controls Nov 22, 2024
@elzody
Copy link
Contributor

elzody commented Nov 22, 2024

Works fine for me 👍🏻

@elzody
Copy link
Contributor

elzody commented Nov 22, 2024

Not merging right away because I wasn't sure to which versions you want to backport (I assume back to stable28?)

@juliusknorr
Copy link
Member Author

juliusknorr commented Nov 25, 2024

I think we only have that api integration in 30+

@juliusknorr
Copy link
Member Author

juliusknorr commented Nov 25, 2024

/backport to stable30

@juliusknorr juliusknorr merged commit 1645f80 into main Nov 25, 2024
69 checks passed
@juliusknorr juliusknorr deleted the fix/transform branch November 25, 2024 19:07
@backportbot backportbot bot mentioned this pull request Nov 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elzody elzody elzody approved these changes

Assignees

No one assigned

Labels

3. to review Ready to be reviewed bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"Undefined array key "type"

3 participants

@juliusknorr @elzody