Skip to content

build: migrate from Webpack to RSPack #16070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ShGKme merged 4 commits into from
Oct 2, 2025
Merged

build: migrate from Webpack to RSPack #16070

ShGKme merged 4 commits into from
Oct 2, 2025

Conversation

@ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Oct 1, 2025 •
edited
Loading

☑️ Resolves

https://rspack.rs

Motivation:

  • MUCH faster (~5 times) with less RAM usage
  • Smaller bundle size due to better tree-shaking
  • Great ecosystem with bundle analysers
  • Webpack-compatible API - super simple migration

Why not Vite:

  • Vite is slow (for Talk slower than Webpack and x2 RAM usage)
  • No good chunks support for web apps: generates hundreds of microchunks

Why not Rolldown:

  • It is released but still under active development
  • Let's see later
Metric Before After
dev build 25 s 4.5 s
prod build 48 s 10 s
bundle size JS 46 MB 38 MB
bundle size CSS 5 MB 2 MB
talk-main.js 6.4 MB 5.9 MB

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@ShGKme ShGKme requested review from Antreesy and DorraJaouad October 1, 2025 13:33
@ShGKme ShGKme self-assigned this Oct 1, 2025
ShGKme added 4 commits October 2, 2025 00:01
@ShGKme
chore(dev-deps): add RSPack
deb0136 
```
npm i -D @rspack/cli @rspack/core @rspack/plugin-node-polyfill \
  css-loader sass-loader vue-loader
```

Signed-off-by: Grigorii K. Shartsev <[email protected]>
@ShGKme
chore: migrate to modern Worker loading
45b424b 
Needed for RSPack compatibility

Signed-off-by: Grigorii K. Shartsev <[email protected]>
@ShGKme
build: migrate to RSPack
d845c0f 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
@ShGKme
chore(dev-deps): remove webpack
3dc6359 
```
npm un @nextcloud/webpack-vue-config \
  babel-loader-exclude-node-modules-except esbuild-loader \
  mini-css-extract-plugin webpack-bundle-analyzer worker-loader
```

Signed-off-by: Grigorii K. Shartsev <[email protected]>
@ShGKme ShGKme marked this pull request as ready for review October 2, 2025 00:08
@ShGKme ShGKme merged commit 9afd8f8 into main Oct 2, 2025
59 checks passed
@ShGKme ShGKme deleted the chore/rspack branch October 2, 2025 12:16
@ShGKme
Copy link
Contributor Author

ShGKme commented Oct 2, 2025

Let me know if you also want it on 32 👀

It also makes the app smaller

@nickvergessen
Copy link
Member

nickvergessen commented Oct 24, 2025

Not for now as I understood?
But we can leave the label for "later"

@ShGKme
Copy link
Contributor Author

ShGKme commented Nov 24, 2025

/backport to stable32

@backportbot backportbot bot mentioned this pull request Nov 24, 2025
Merged
2 tasks
@ShGKme
Copy link
Contributor Author

ShGKme commented Nov 24, 2025

  • Talk Desktop doesn't depend on Talk's bundler anymore
  • New features are compatible with both

@juliusknorr juliusknorr mentioned this pull request Dec 21, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@Antreesy Antreesy Antreesy approved these changes

Assignees

@ShGKme ShGKme

Labels

3. to review technical debt

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ShGKme @nickvergessen @DorraJaouad @Antreesy