Skip to content

Conversation

@enoch85
Copy link
Member

@enoch85 enoch85 commented Apr 27, 2023

cc @szaimen Your take on this?

It's according to docs. Are there more formats supported by Imagniary? I saw that Krita was another supported format?

cc  @szaimen Your take on this?

It's according to docs. Are there more formats supported by Imagniary? I saw that Krita was another supported format?

Signed-off-by: Daniel Hansson <[email protected]>
Co-authored-by: Simon L. <[email protected]>
Signed-off-by: Daniel Hansson <[email protected]>
@enoch85
Copy link
Member Author

enoch85 commented Apr 27, 2023

Why not PDF and HEIC? I saw that you added support for PDF in the last release.

Co-authored-by: Simon L. <[email protected]>
Signed-off-by: Daniel Hansson <[email protected]>
@szaimen
Copy link
Collaborator

szaimen commented Apr 27, 2023

Why not PDF and HEIC? I saw that you added support for PDF in the last release.

because it is already included here: https://github.com/nextcloud/server/blob/5e96228eb1f7999a327dacab22055ec2aa8e28a3/lib/private/Preview/Imaginary.php#L60

@enoch85
Copy link
Member Author

enoch85 commented Apr 27, 2023

Why not PDF and HEIC? I saw that you added support for PDF in the last release.

because it is already included here: https://github.com/nextcloud/server/blob/5e96228eb1f7999a327dacab22055ec2aa8e28a3/lib/private/Preview/Imaginary.php#L60

Ah ok, but still strange that PDFs weren't generated without adding it as enabled. I'll need to double check.

Anyway, are there any more formats that can be enabled?

@szaimen
Copy link
Collaborator

szaimen commented Apr 27, 2023

Anyway, are there any more formats that can be enabled?

Probably Krita indeed as it is not covered by imaginary.

Signed-off-by: Daniel Hansson <[email protected]>
Copy link
Collaborator

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@enoch85 enoch85 merged commit 6772a66 into master Apr 27, 2023
@delete-merged-branch delete-merged-branch bot deleted the imaginary-fixes branch April 27, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants