Skip to content

Conversation

@pq2
Copy link
Contributor

@pq2 pq2 commented May 9, 2025

"--prefix" has been deprecated. "--glob-archives 'yourprefix*'" (-a) should be used instead.

Copy link
Collaborator

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for your PR! Just a few small comments above

Co-authored-by: Simon L. <[email protected]>
Signed-off-by: pq2 <[email protected]>
@szaimen
Copy link
Collaborator

szaimen commented Jun 4, 2025

Thanks @pq2! Only two additional places and then is this ready to go :)

pq2 and others added 2 commits June 4, 2025 15:46
Co-authored-by: Simon L. <[email protected]>
Signed-off-by: pq2 <[email protected]>
Co-authored-by: Simon L. <[email protected]>
Signed-off-by: pq2 <[email protected]>
Copy link
Collaborator

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot! 😊

@pq2
Copy link
Contributor Author

pq2 commented Jun 4, 2025

Should be all done now. Sorry this took so long and was so unnecessarily complicated, and thanks for adding the changes yourself. I had suggested my initial changes directly via Github and hadn't yet found the time to clone the repo and make the suggested changes to my branch myself.

@szaimen
Copy link
Collaborator

szaimen commented Jun 4, 2025

Should be all done now. Sorry this took so long and was so unnecessarily complicated, and thanks for adding the changes yourself. I had suggested my initial changes directly via Github and hadn't yet found the time to clone the repo and make the suggested changes to my branch myself.

All good :)

@enoch85
Copy link
Member

enoch85 commented Jun 5, 2025

Thanks guys 👍🏼✅

@enoch85 enoch85 merged commit 9a32c86 into nextcloud:main Jun 5, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants