-
-
Notifications
You must be signed in to change notification settings - Fork 673
Fix deprecation warning #2743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deprecation warning #2743
Conversation
Signed-off-by: pq2 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for your PR! Just a few small comments above
Co-authored-by: Simon L. <[email protected]> Signed-off-by: pq2 <[email protected]>
Co-authored-by: Simon L. <[email protected]> Signed-off-by: pq2 <[email protected]>
|
Thanks @pq2! Only two additional places and then is this ready to go :) |
Co-authored-by: Simon L. <[email protected]> Signed-off-by: pq2 <[email protected]>
Co-authored-by: Simon L. <[email protected]> Signed-off-by: pq2 <[email protected]>
szaimen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks a lot! 😊
|
Should be all done now. Sorry this took so long and was so unnecessarily complicated, and thanks for adding the changes yourself. I had suggested my initial changes directly via Github and hadn't yet found the time to clone the repo and make the suggested changes to my branch myself. |
All good :) |
|
Thanks guys 👍🏼✅ |
"--prefix" has been deprecated. "--glob-archives 'yourprefix*'" (-a) should be used instead.