Numerous bugfixes #2772
Merged
Numerous bugfixes #2772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix #2738, #2769, #2724: Migrate from AdminerEvo to AdminerNeo * AdminerEvo project has been archived * Updated to use AdminerNeo v1.0.2 from GitHub releases * Added proper error handling and file validation - Fix #2731, #2697: ElasticSearch version detection * Improved regex to extract version numbers from any position * Added validation to ensure proper version format * Added fallback to known stable version (8.16.1) if detection fails - Fix #2761, #2727: PostgreSQL schema permissions for NC 30+ * Added GRANT CREATE ON SCHEMA public for fresh installations * Added migration fix in update script for existing installations * PostgreSQL 15+ requires explicit schema permissions - Fix #2701, #2674: GeoBlock installation improvements * Better error handling for apache2-dev dependency conflicts * Added dependency fix attempts before failing * Improved compilation error messages * Added verification that apxs tool is available * Better progress feedback during compilation
Use the standard install_if_not function for apache2-dev installation instead of calling apt-get install -y directly, following the established codebase pattern.
- Fix NCUSER typo -> NCDBUSER in nextcloud_update.sh - Replace indirect exit code check with direct check in nextcloud_install_production.sh
- Update to AdminNeo 5.1.1 (current stable version) - Fix download URL to use www.adminneo.org/files/ instead of GitHub releases - Project renamed from AdminerNeo to AdminNeo - Download direct PHP file instead of ZIP archive - Simplify file handling (no unzip needed) - Update documentation URLs
Spelling fixes: - Fix NCUSER -> NCDBUSER typo in nextcloud_update.sh (lines 101, 102, 107) - Fix 'recomended' -> 'recommended' in apps/imaginary.sh - Fix 'usally' -> 'usually' in apps/talk.sh - Fix 'recomend' -> 'recommend' in menu/documentserver.sh - Fix 'Improvments' -> 'Improvements' in torrent/create.sh AdminNeo improvements: - Move ADMINER_VERSION and ADMINER_DOWNLOAD_URL to lib.sh - Add dynamic version detection via GitHub API - Automatically fetch latest AdminNeo version with fallback to 5.1.1 - Remove hardcoded version from apps/adminer.sh
Automatic database permission changes during unattended updates is risky business. Keep only the fresh installation fix in nextcloud_install_production.sh where it's done during initial setup. Users with existing installations who need the fix can apply it manually if they encounter permission errors during NC 30+ upgrade.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix AdminerEvo cannot be downloaded #2738, Install Adminer #2769, Replace AdminerEvo with AdminNeo #2724: Migrate from AdminerEvo to AdminerNeo
Fix Shipped lib.sh sets elasticsearch docker image tag to 1.53.5 resulting in infinite retry #2731, Elasticsearch fails #2697: ElasticSearch version detection
Fix [Bug]: PostgreSQL database
GRANTs out-of-date (was "db:add-missing-indices not working anymore") #2761, Upgrade from Nextcloud 29 to 30 fails with SQL permission error #2727: PostgreSQL schema permissions for NC 30+Fix Maxminddb Reinstall Failed #2701, Nextcloud VM GeoBlock broken #2674: GeoBlock installation improvements