Fix LVM snapshot and disk space logic (closes #1986) #2779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ask about snapshots first before disk space question - Reserve 10G for snapshots, then extend with remaining free space - This prevents the bug where extending to 100%FREE consumed space needed for snapshots - Provisioning mode still always extends as before - Fix whiptail installation to run apt-get update first
- Export variables when set to make them available to child processes - Unset them after use to clean up the environment - Fixes shellcheck SC2034 warning
enoch85
force-pushed
the
fix-lvm-snapshot-disk-space-logic
branch
from
e7b1492 to
dc89b5e
Compare
szaimen
reviewed
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@szaimen