Skip to content

Conversation

@fidanf
Copy link
Contributor

@fidanf fidanf commented Dec 28, 2021

Proposed changes

Make role backward-compatble for Ansible versions 2.x, 3.x & 4 omitting recent module parameters when necessary.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have added Molecule tests that prove my fix is effective or that my feature works
  • I have checked that any relevant Molecule tests pass after adding my changes
  • I have updated any relevant documentation (defaults/main/*.yml, README.md and CHANGELOG.md)

@fidanf fidanf changed the title Feat ansible base compatibility Feat: ansible-base compatibility Dec 28, 2021
@fidanf
Copy link
Contributor Author

fidanf commented Jan 12, 2022

@alessfg Hello, could we run another build ? Upgrade scenario might now be fixed, hopefully

@fidanf fidanf closed this Jan 31, 2022
@fidanf fidanf deleted the feat-ansible-base-compatibility branch January 31, 2022 14:44
@alessfg
Copy link
Member

alessfg commented Feb 2, 2022

Hey there! I see you closed this PR -- the tests were failing due to Ansible Lint running into some edge dependency issues. I'm currently trying to update the role to the latest version of Ansible Lint (as well as fix other issues stemming from the latest couple NGINX updates), but once I get those fixes in, I can try merging this PR if you want to reopen it. Plus, this PR should partially address #478 so that's an extra bonus.

@fidanf
Copy link
Contributor Author

fidanf commented Feb 2, 2022

Hey there! I see you closed this PR -- the tests were failing due to Ansible Lint running into some edge dependency issues. I'm currently trying to update the role to the latest version of Ansible Lint (as well as fix other issues stemming from the latest couple NGINX updates), but once I get those fixes in, I can try merging this PR if you want to reopen it. Plus, this PR should partially address #478 so that's an extra bonus.

Hello.
Sure I'd reopen it for another attempt the moment you get that fixed!
Thanks

@fidanf fidanf mentioned this pull request Feb 8, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants