Skip to content

strictStateImmutability + RouterState.Full incompatible with each other #2016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
luchsamapparat opened this issue Jul 13, 2019 · 3 comments · Fixed by #2022
Closed

strictStateImmutability + RouterState.Full incompatible with each other #2016

luchsamapparat opened this issue Jul 13, 2019 · 3 comments · Fixed by #2022
Assignees
Labels
Accepting PRs community watch Someone from the community is working this issue/PR Comp: Docs Project: Store

Comments

@luchsamapparat
Copy link
Contributor

luchsamapparat commented Jul 13, 2019

Enabling strictStateImmutability together with RouterState.Full as router state serialization leads to errors that are very hard to track down (see angular/angular#31523, #1937), so the runtime check documentation should probably include a warning that those to configurations are not compatible with each other.

And for future (major) releases the Minimal router serialization should maybe be the default...?

I would be willing to submit a PR for the docs ❤️

[X] Yes (Assistance is provided if you need help submitting a pull request)
[ ] No

@luchsamapparat luchsamapparat changed the title strictStateImmutability + RouterState.Full incompatible with Angular Ivy strictStateImmutability + RouterState.Full incompatible with each other Jul 13, 2019
@timdeschryver
Copy link
Member

This is not the first time I see this question, so I agree that it would good to add a warning here.

Do you want to pick this one up @luchsamapparat ?

@luchsamapparat
Copy link
Contributor Author

I'll create a PR on Friday 👍

@wawyed
Copy link

wawyed commented Jun 28, 2022

Sorry to bring up an old post but I'm using the MinimalRouterStateSerializer but I'm still getting CannotFreeze error from strictStateImmutability. Is this a regression?

I'm on version 14

EDIT: Looks like that if you have a router resolve with a class with Observables you won't be able to use ngrx router store as it won't be able to serialise the routerAction.payload.routerState on the routerReducer function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepting PRs community watch Someone from the community is working this issue/PR Comp: Docs Project: Store
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants