Add Eversense CGM to Trio (open beta, feature-branch)#982
Add Eversense CGM to Trio (open beta, feature-branch)#982dnzxy merged 3 commits intonightscout:feat/dev-eversensefrom
Conversation
|
@marionbarker Regarding your comment here: #978 (comment) Maybe this PR helps the Eversense user? |
TestStarted with bastiaanv / Trio branch: feat/eversense Add Eversense as CGM
|
marionbarker
left a comment
There was a problem hiding this comment.
Code review
Some of the updates are to bring dev up to date so the file changes that are strictly due to adding Eversense are mixed with updates to dev.
This would not be my choice but I leave this up to the Trio developers to decide.
I think it would be better to stick with PR #976, make the fixes there and then after merging that, update the feat/dev-eversense branch by merging in dev.
Test
The test using this code plus selecting Eversense commit e870c22c is good to go.
|
Alternatively - have someone merge dev into nightscout / Trio branch feat/dev-eversense and then this PR would be just what is needed to add Eversense to Trio. |
|
@dnzxy or @MikePlante1 Would one of you be able to merge dev into the feature branch? |
|
Okay, latest dev is now merged into the feat/dev-eversense (and feat/dev-medtrum) branch in nightscout/Trio
|
|
Not as clean of a PR as I would have wanted :) |
marionbarker
left a comment
There was a problem hiding this comment.
Thank you for cleaning up the repository branches to provide a clean diff.
My only question (and this can come later) is do we need to add anything to onboarding.
You do not onboard any device during Trio‘s onboarding. You only select a pump model to get to basal increments via a hard coded enum based list of available increments. So, no, I don’t think so. Merging this if @bastiaanv is happy and ready, and another Trio dev (@MikePlante1 , @kingst ) approves. |
MikePlante1
left a comment
There was a problem hiding this comment.
Code review looks good.
Browser builds fine.
Xcode builds without linting.
✅ LGTM
|
I am happy and ready 😄 |
|
Maybe it's a dumb question, but can this branch also be used with Loop? |
|
Hey! |
|
For more information, see LoopDocs. https://loopkit.github.io/loopdocs/version/development/#table-of-active-branches |
Adding EversenseKit as new CGM option for Trio.
And syncing with dev branch
Fresh PR based on feedback from: #978
TODO's: