-
Notifications
You must be signed in to change notification settings - Fork 24
Adds Tenancy/Contacts and Contact Groups #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@fr3nch13 thank you! Could you rebase your branch? I'll create a release as soon as this one is merged. |
Done. I'll most likely be adding more entities/relationships in the coming days, but a release with this one would be greatly appreciated! |
It still creates conflicts. So I wait for now. |
In Github it's showing: No conflicts with base branch Am I missing somethings? |
From my end, the merge conflict was in the When I rebased, everything was resolved on my end, so I'm not able to see what you're seeing. |
Can we approve this PR? Is there anything else you need from me? |
I already did that two weeks ago, but the branch still had conflicts:
I rebased it and merged your changes in #96 |
Thank you @thde i really appreciate it. I'm sure I'll have more changes and more PRs. :-) |
You're right, it is pretty trivial to create new Entity definitions.
Anyway, I needed contacts and contact groups, so I figured I'd add them here. As I work through my project, and find other entities that have a relationship with contacts, I'll open another PR to add those relationships.