Skip to content

feat: ibc support#28

Merged
johnletey merged 20 commits into
v2from
ibc-support
Apr 2, 2025
Merged

feat: ibc support#28
johnletey merged 20 commits into
v2from
ibc-support

Conversation

@johnletey
Copy link
Copy Markdown
Member

No description provided.

@johnletey johnletey self-assigned this Mar 7, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 7, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@johnletey johnletey changed the base branch from main to v2 March 14, 2025 12:20
@johnletey johnletey marked this pull request as ready for review March 14, 2025 12:28
Copy link
Copy Markdown
Contributor

@0xstepit 0xstepit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Added a couple of comments

Comment thread keeper/msg_server.go Outdated
Comment thread keeper/query_server.go Outdated
Comment thread proto/noble/dollar/v1/events.proto Outdated
Comment thread utils/mocks/bank.go Outdated
Comment thread e2e/ibc_test.go Outdated
Comment thread utils/vaa.go Outdated
Comment thread proto/noble/dollar/v1/dollar.proto Outdated
Copy link
Copy Markdown
Member

@jtieri jtieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work John! The design is pretty simple and the code changes are pretty straightforward. Solid e2e test as well 💪

It would be good to document the design/flow of how this works though for internal use but also so we can point users to it as we start to onboard chains.

Comment thread types/portal/payload.go Outdated
Comment thread types/channel.go Outdated
Comment thread types/channel.go Outdated
Comment thread utils/mocks/bank.go Outdated
Comment thread utils/address.go
Comment thread e2e/ibc_test.go Outdated
Comment thread e2e/ibc_test.go Outdated
Comment thread e2e/ibc_test.go Outdated
Comment thread e2e/ibc_test.go Outdated
Comment thread e2e/ibc_test.go Outdated
@johnletey johnletey requested review from 0xstepit and jtieri March 27, 2025 18:20
@johnletey johnletey added this to the v2 milestone Mar 27, 2025
Copy link
Copy Markdown
Member

@jtieri jtieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated changes look good! Only had one small comment.

Also approved #30 so should be good to merge and update.

Comment thread keeper/query_server_v2.go Outdated
@johnletey johnletey requested a review from jtieri April 1, 2025 09:13
Copy link
Copy Markdown
Member

@jtieri jtieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🚢 🚢

@johnletey johnletey merged commit 83a5546 into v2 Apr 2, 2025
4 checks passed
@johnletey johnletey deleted the ibc-support branch April 2, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants