NPM Install caching #301
NPM Install caching #301
Conversation
…NpmInstallTask - add tests for `npmInstall` task caching - add test fixture project for `npmInstall` caching
deepy
left a comment
deepy
left a comment
There was a problem hiding this comment.
Doing an initial review of the changes, but because of the issues listed in #81 (comment) we probably can't merge this
By probably I mean unless someone can make a compelling argument for why we want to support this and would be prepared to spend a little time looking at the test setup
| //@Optional | ||
| //@OutputFile | ||
| @Internal | ||
| protected fun getPackageLockFileAsOutput(): File? { |
There was a problem hiding this comment.
Instead of removing the @Optional @OutputFile you probably want to follow the pattern below
i.e. add a configurable flag for which behaviour and if it's set to the new behaviour then just return null here immediately
(Though at that point I suspect all the output methods might need to be reworked slightly, but that's boring tedious work and you can happily leave that to the maintainers)
|
Closing, because I've since thought of a better approach #81 (comment) |
2 participants
Allow
npmInstallto be cached (helps with #81)npmInstalltask cachingnpmInstallcachingFor demonstration purposes, I commented-out the overlapping outputs in NpmInstallTask. This will have knock-on effects that I haven't tackled - I just wanted to demonstrate what it would take to get my test working.