test: convert most addons-napi tests to C#190
Closed
gabrielschulhof wants to merge 2 commits intonodejs:api-prototype-8.xfrom
Closed
test: convert most addons-napi tests to C#190gabrielschulhof wants to merge 2 commits intonodejs:api-prototype-8.xfrom
gabrielschulhof wants to merge 2 commits intonodejs:api-prototype-8.xfrom
Conversation
gabrielschulhof
force-pushed
the
183-addons-in-c
branch
from
3a401ee to
ed3c7fa
Compare
gabrielschulhof
pushed a commit
to gabrielschulhof/abi-stable-node
that referenced
this pull request
Mar 22, 2017
Some tests need to stay C++ because they define classes. Fixes nodejs#183 Closes nodejs#190
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Some tests need to stay C++ because they define classes. Fixes nodejs#183 Closes nodejs#190
gabrielschulhof
force-pushed
the
183-addons-in-c
branch
2 times, most recently
from
81e29a6 to
f388004
Compare
gabrielschulhof
force-pushed
the
183-addons-in-c
branch
from
f388004 to
64a26ba
Compare
Collaborator
Author
|
https://ci.nodejs.org/view/x%20-%20Abi%20stable%20module%20API/job/node-test-commit-linux-abi/75/ There are some failures there, but not on archs we normally run, and from what I can tell, they are related to the configuration of the bots, not the code changes. I also ran on AIX: https://ci.nodejs.org/view/x%20-%20Abi%20stable%20module%20API/job/node-test-commit-aix-abi/50/ |
jasongin
pushed a commit
to jasongin/nodejs
that referenced
this pull request
Mar 23, 2017
Some tests need to stay C++ because they define classes. Fixes nodejs/abi-stable-node#183 Closes nodejs/abi-stable-node#190
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some tests need to stay C++ because they define classes.
Fixes #183