Skip to content

fix: Python lint import-outside-top-level ruff rule PLC0415 #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 22, 2025
Merged

fix: Python lint import-outside-top-level ruff rule PLC0415 #298

merged 2 commits into from
Jun 22, 2025

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jun 22, 2025 •
edited
Loading

Failing lint tests https://docs.astral.sh/ruff/rules/import-outside-top-level

Most of these are about operating system-specific modules, such as WinReg, etc.

Like node-gyp:

Also, in pyproject.toml, use project.requires-python, not tool.ruff.target-version.

@legendecas legendecas merged commit 34f4df6 into nodejs:main Jun 22, 2025
42 checks passed
@github-actions github-actions bot mentioned this pull request Jun 22, 2025
Merged
@cclauss cclauss deleted the ruff-rule-PLC0415 branch June 22, 2025 10:52
@cclauss cclauss mentioned this pull request Jun 22, 2025
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legendecas legendecas legendecas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cclauss @legendecas