benchmark: ES6 class vs function benchmark#11609
Closed
jasnell wants to merge 1 commit intonodejs:masterfrom
Closed
benchmark: ES6 class vs function benchmark#11609jasnell wants to merge 1 commit intonodejs:masterfrom
jasnell wants to merge 1 commit intonodejs:masterfrom
Conversation
e2cfbba to
c6b5bfa
Compare
Member
Author
|
@nodejs/v8 @fhinkel ... what's the status on optimizing ES6 class use? |
c6b5bfa to
3bd6486
Compare
A simple benchmark comparing ES6 classes with idiomatic ES5 "old style" classes using function and util.inherits
3bd6486 to
7428fde
Compare
Member
Author
|
What this benchmark does show is that using ES6 Classes is currently significantly faster than the current pattern of using Functions coupled with the instanceof check to catch non-use of new. |
joyeecheung
reviewed
Mar 7, 2017
| millions: [10] | ||
| }); | ||
|
|
||
| class FooBase { |
Member
There was a problem hiding this comment.
Might be a bit easier to read if these are ES6BaseClass, ES6Subclass, FunctionWithNewCheck...(not necessary to be so verbose, just not Foo Bar)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A simple benchmark comparing ES6 classes with idiomatic ES5 "old style" classes using function and util.inherits
In the current codebase, using
function()with aninstanceofcheck to catch whennewis not used is the most common pattern. As the benchmark shows, theinstanceofcheck is quite expensive. That said, using function without the instanceof check is still faster than using an ES6 class.Using the
--ignitiontoolchain, the results are quite a bit different:/cc @nodejs/benchmarking @mscdex
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
benchmark