Skip to content

net: always invoke after-write callback #24291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 2 commits into from
Closed

net: always invoke after-write callback #24291

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a753716
net: always invoke after-write callback
addaleax Nov 10, 2018
c54ef53
fixup! net: always invoke after-write callback
addaleax Nov 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/net.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -776,6 +776,8 @@ function afterWrite(status, handle, err) {
// callback may come after call to destroy.
if (self.destroyed) {
debug('afterWrite destroyed');
if (this.callback)
this.callback(null);
return;
}

Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-tls-invoke-queued.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ const server = tls.createServer({
c.destroy();
}));
// Data on next _write() will be written but callback will not be invoked
Comment thread
addaleax marked this conversation as resolved.
Outdated
c.write(' gosh', null, common.mustNotCall());
c.write(' gosh', null, common.mustCall());
}));

server.close();
Expand Down