Skip to content

src: Modernized unique_ptr construction #31654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Yuhanun wants to merge 2 commits into from
Closed

src: Modernized unique_ptr construction #31654

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc87cd1
Modernized unique_ptr construction
Feb 5, 2020
7c62374
Resolved an issue where a unique_ptr would not allocate
Feb 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/debug_utils.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,16 +100,14 @@ class PosixSymbolDebuggingContext final : public NativeSymbolDebuggingContext {

std::unique_ptr<NativeSymbolDebuggingContext>
NativeSymbolDebuggingContext::New() {
return std::unique_ptr<NativeSymbolDebuggingContext>(
new PosixSymbolDebuggingContext());
return std::make_unique<PosixSymbolDebuggingContext>();
}

#else // HAVE_EXECINFO_H

std::unique_ptr<NativeSymbolDebuggingContext>
NativeSymbolDebuggingContext::New() {
return std::unique_ptr<NativeSymbolDebuggingContext>(
new NativeSymbolDebuggingContext());
return std::unique_ptr<NativeSymbolDebuggingContext>();
Comment thread
Yuhanun marked this conversation as resolved.
Outdated
}

#endif // HAVE_EXECINFO_H
Expand Down