Skip to content

tools: use using-declaration consistently #36245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danbev wants to merge 2 commits into from
Closed

tools: use using-declaration consistently #36245

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fb7475
tools: use using-declaration consistently
danbev Nov 24, 2020
357f471
fixup! tools: use using-declaration consistently
danbev Nov 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tools/snapshot/snapshot_builder.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ void WriteVector(std::stringstream* ss, const T* vec, size_t size) {
}
}

std::string FormatBlob(v8::StartupData* blob,
std::string FormatBlob(StartupData* blob,
const std::vector<size_t>& isolate_data_indexes,
const EnvSerializeInfo& env_info) {
std::stringstream ss;
Expand Down Expand Up @@ -75,7 +75,7 @@ const EnvSerializeInfo* NodeMainInstance::GetEnvSerializeInfo() {
return ss.str();
}

static v8::StartupData SerializeNodeContextInternalFields(Local<Object> holder,
static StartupData SerializeNodeContextInternalFields(Local<Object> holder,
int index,
void* env) {
Comment thread
danbev marked this conversation as resolved.
Outdated
void* ptr = holder->GetAlignedPointerFromInternalField(index);
Expand Down