sqlite: add build option to build without sqlite #58122
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Dawson <[email protected]>
|
Review requested:
|
nodejs-github-bot
added
lib / src
Signed-off-by: Michael Dawson <[email protected]>
anonrig
reviewed
May 2, 2025
| @@ -883,6 +885,7 @@ const common = { | |||
| hasIntl, | |||
| hasCrypto, | |||
| hasQuic, | |||
| hasSQLite, | |||
There was a problem hiding this comment.
Can we move the declaration here?
There was a problem hiding this comment.
@anonrig can you clarify what you mean on this one?
There was a problem hiding this comment.
Instead of having the variable declaration on top of the file, what about:
Suggested change
| hasSQLite, | |
| hasSQLite: Boolean(...), |
There was a problem hiding this comment.
That is not consistent with how any of the other ones are done as far as I can see. I was just trying to follow what seems to be existing practice.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58122 +/- ##
==========================================
- Coverage 90.20% 90.14% -0.07%
==========================================
Files 630 630
Lines 186391 186784 +393
Branches 36612 36651 +39
==========================================
+ Hits 168134 168369 +235
- Misses 11068 11199 +131
- Partials 7189 7216 +27
🚀 New features to boost your workflow:
|
Signed-off-by: Michael Dawson <[email protected]>
|
@anonrig addressed all of your comments except the one I asked for clarification on . |
geeksilva97
reviewed
May 2, 2025
geeksilva97
approved these changes
May 2, 2025
github-actions
bot
removed
the
request-ci
RafaelGSS
approved these changes
May 5, 2025
aduh95
reviewed
May 6, 2025
Signed-off-by: Michael Dawson <[email protected]>
jasnell
approved these changes
May 7, 2025
geeksilva97
added
the
author ready
mhdawson
added
the
commit-queue-squash
mhdawson
added a commit
that referenced
this pull request
May 7, 2025
Signed-off-by: Michael Dawson <[email protected]> PR-URL: #58122 Reviewed-By: Edy Silva <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in 535c2f7 |
targos
pushed a commit
that referenced
this pull request
May 16, 2025
Signed-off-by: Michael Dawson <[email protected]> PR-URL: #58122 Reviewed-By: Edy Silva <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Distributors of Node.js may want to ship without all of surface area so in some cases
build time options are provided to to that.
I was asked by the RHEL team to add an option to build without sqlite so that have that
flexibility and this PR does that.