src: remove NonCopyableMaybe #58168
Merged
src: remove NonCopyableMaybe #58168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added this class in 823d86c in 2018 when we did not yet use `std::optional`. The last uses were removed in 5b9bf39, so remove it. Refs: nodejs#24234 Refs: nodejs#55368
tniessen
added
the
c++
cjihrig
approved these changes
May 4, 2025
BridgeAR
approved these changes
May 4, 2025
BridgeAR
added
author ready
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
juanarbol
approved these changes
May 4, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58168 +/- ##
==========================================
- Coverage 90.13% 90.12% -0.01%
==========================================
Files 630 630
Lines 186611 186611
Branches 36631 36635 +4
==========================================
- Hits 168204 168188 -16
- Misses 11192 11194 +2
- Partials 7215 7229 +14
🚀 New features to boost your workflow:
|
Flarna
approved these changes
May 4, 2025
daeyeon
approved these changes
May 5, 2025
marco-ippolito
approved these changes
May 5, 2025
Flarna
added
the
commit-queue
bjohansebas
approved these changes
May 5, 2025
lpinca
approved these changes
May 5, 2025
nodejs-github-bot
removed
the
commit-queue
|
Landed in b0f2aa9 |
targos
pushed a commit
that referenced
this pull request
May 16, 2025
I added this class in 823d86c in 2018 when we did not yet use `std::optional`. The last uses were removed in 5b9bf39, so remove it. Refs: #24234 Refs: #55368 PR-URL: #58168 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added this class in 823d86c in 2018 when we did not yet use
std::optional. The last uses were removed in 5b9bf39, so remove it.Refs: #24234
Refs: #55368