Skip to content

test: fix flaky test/fs-read-buffer-tostring-fail #7575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 2 commits into from
Closed

test: fix flaky test/fs-read-buffer-tostring-fail #7575

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01db593
test: fix flaky test/fs-read-buffer-tostring-fail
Trott Jul 7, 2016
6e00a03
squash: move
Trott Jul 7, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions test/parallel/test-fs-read-buffer-tostring-fail.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
'use strict';

const common = require('../common');

const skipMessage = 'intensive toString tests due to memory confinements';
Copy link
Copy Markdown
Contributor

@mscdex mscdex Jul 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't there need to be a header here or something, like the other tests that have a similar skip message?

Copy link
Copy Markdown
Member Author

@Trott Trott Jul 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what you mean. Here's another example:

node/test/addons/stringbytes-external-exceed-max/test-stringbytes-external-at-max.js

Lines 11 to 15 in b10ee9d

const skipMessage = 'intensive toString tests due to memory confinements';
if (!common.enoughTestMem) {
common.skip(skipMessage);
return;
}

And here's what this test pass when it skips:

1..0 # Skipped: intensive toString tests due to memory confinements

Copy link
Copy Markdown
Member Author

@Trott Trott Jul 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I'll run CI and see what happens on the Raspberry Pi devices...

Copy link
Copy Markdown
Contributor

@mscdex mscdex Jul 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, I didn't realize .skip() was adding the necessary header.

if (!common.enoughTestMem) {
common.skip(skipMessage);
return;
}

const assert = require('assert');
const fs = require('fs');
const path = require('path');
Expand Down