[tests]Changed var -> const, assert.equal -> assert.strictEqual#9884
Closed
troy0820 wants to merge 1 commit intonodejs:masterfrom
Closed
[tests]Changed var -> const, assert.equal -> assert.strictEqual#9884troy0820 wants to merge 1 commit intonodejs:masterfrom
troy0820 wants to merge 1 commit intonodejs:masterfrom
Conversation
imyller
added
the
code-and-learn
princejwesley
approved these changes
Dec 1, 2016
Contributor
|
@troy0820 please change the commit msg as |
cjihrig
approved these changes
Dec 1, 2016
Contributor
Author
|
Changed commit message @princejwesley 💥 👍 |
troy0820
force-pushed
the
troy0820-edit-test
branch
from
48528b5 to
081cdc0
Compare
lpinca
approved these changes
Dec 2, 2016
targos
approved these changes
Dec 3, 2016
jasnell
approved these changes
Dec 3, 2016
Member
jasnell
left a comment
jasnell
left a comment
There was a problem hiding this comment.
LGTM! Thank you for participating in Code and Learn! Welcome to Node.js!
Member
|
@troy0820 I'm really sorry about this but it looks like I messed up and gave a small number of people duplicate tasks at the Code & Learn. Unfortunately, this was one of them. Would it be OK with you if we closed this one and I privately sent you another similar task? This is totally my fault and I apologize. |
Contributor
Author
|
@Trott That's perfectly alright. Whatever you need me to do just send my way and I'll do that. 👍🏽 |
Contributor
|
Closing. Sorry about the confusion. |
This was referenced Apr 24, 2023
This was referenced Apr 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Tests
Description of change
vartoconstassert.equaltoassert.strictEqual