Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryMedium Risk Overview Removes the Orama Cloud sync workflow/script/tests and deletes the site-level Searchbox/chat components; the navbar now mounts the new Updates Reviewed by Cursor Bugbot for commit 23e4c7b. Bugbot is set up for automated code reviews on this repo. Configure here. |
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/web-infra @nodejs/nodejs-website Please review the changes when you have a chance. Thank you! 🙏 |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
This PR migrates the website search integration away from Orama Cloud toward a locally generated (and locally loaded) Orama database that merges the Learn + API docs indexes.
Changes:
- Generate a merged
orama-db.jsonduring site prebuild and load it client-side for search. - Replace the site’s Orama Cloud searchbox + chat integration with the UI-components
SearchBoxwired to the local DB. - Remove Orama Cloud configuration, sync workflow, and related scripts/tests.
Reviewed changes
Copilot reviewed 44 out of 46 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Updates lockfile for Orama package changes across workspaces. |
| packages/ui-components/src/hooks/useOrama.ts | Adds a hook to create a local Orama DB and lazy-load it from a JSON snapshot. |
| packages/ui-components/src/Common/Search/index.tsx | Adds a new SearchBox component that uses the local Orama hook. |
| packages/ui-components/src/Common/Search/index.module.css | Styles for the new SearchBox layout/footer. |
| packages/ui-components/src/Common/Search/Suggestions/index.tsx | Removes suggestions component (part of prior chat/suggestions UX). |
| packages/ui-components/src/Common/Search/Suggestions/index.module.css | Removes styles for suggestions component. |
| packages/ui-components/src/Common/Search/Results/index.tsx | Hardcodes search params (limit/threshold/boost) rather than receiving them from site. |
| packages/ui-components/src/Common/Search/Results/Hit/index.tsx | Simplifies hit rendering by removing now-unused chat/search mode handling. |
| packages/ui-components/src/Common/Search/README.md | Removes Orama search component README. |
| packages/ui-components/src/Common/Search/Chat/Trigger/index.tsx | Removes chat trigger UI. |
| packages/ui-components/src/Common/Search/Chat/Trigger/index.module.css | Removes chat trigger styles. |
| packages/ui-components/src/Common/Search/Chat/Input/index.tsx | Removes chat input UI. |
| packages/ui-components/src/Common/Search/Chat/Input/index.module.css | Removes chat input styles. |
| packages/ui-components/src/Common/Search/Chat/Actions/index.tsx | Removes chat actions UI. |
| packages/ui-components/src/Common/Search/Chat/Actions/index.module.css | Removes chat actions styles. |
| packages/ui-components/package.json | Swaps dependencies to use @orama/orama and moves @orama/core. |
| apps/site/turbo.json | Removes Orama Cloud env vars from turbo pipeline config. |
| apps/site/scripts/orama/index.mjs | New script that fetches two remote Orama DBs, merges them, and writes public/orama-db.json. |
| apps/site/scripts/orama/constants.mjs | Adds constants for remote Orama DB URLs. |
| apps/site/scripts/orama-search/sync-orama-cloud.mjs | Removes Orama Cloud sync script. |
| apps/site/scripts/orama-search/process-documents.mjs | Removes old document processing for cloud sync. |
| apps/site/scripts/orama-search/get-documents.mjs | Removes old document fetching logic for cloud sync. |
| apps/site/scripts/orama-search/tests/process-documents.test.mjs | Removes tests for deleted processing logic. |
| apps/site/scripts/orama-search/tests/get-documents.test.mjs | Removes tests for deleted fetching logic. |
| apps/site/package.json | Runs Orama DB generation in prebuild/dev/deploy and removes cloud sync script entry. |
| apps/site/next.constants.mjs | Removes Orama Cloud constants and default query/suggestions config. |
| apps/site/components/withSearch.tsx | New wrapper component that mounts the new SearchBox. |
| apps/site/components/withNavBar.tsx | Re-enables search in the navbar via the new wrapper. |
| apps/site/components/Common/Searchbox/orama-client.ts | Removes Orama Cloud client initialization. |
| apps/site/components/Common/Searchbox/index.tsx | Removes old site-specific searchbox (chat + suggestions + i18n wiring). |
| apps/site/components/Common/Searchbox/index.module.css | Removes old searchbox styles. |
| apps/site/components/Common/Searchbox/SlidingChatPanel/index.tsx | Removes sliding chat panel. |
| apps/site/components/Common/Searchbox/SlidingChatPanel/index.module.css | Removes sliding chat panel styles. |
| apps/site/components/Common/Searchbox/SearchItem/utils.ts | Removes old hit formatting + locale/base-path link building utilities. |
| apps/site/components/Common/Searchbox/SearchItem/index.tsx | Removes old adapter from Orama hit docs to UI-components hit rendering. |
| apps/site/components/Common/Searchbox/Footer/index.tsx | Removes old footer (powered-by + shortcuts). |
| apps/site/components/Common/Searchbox/Footer/index.module.css | Removes old footer styles. |
| apps/site/components/Common/Searchbox/DocumentLink/index.tsx | Removes locale-aware next/link wrapper for search/chat sources. |
| apps/site/components/Common/Searchbox/ChatSources/index.tsx | Removes chat sources UI. |
| apps/site/components/Common/Searchbox/ChatSources/index.module.css | Removes chat sources styles. |
| apps/site/components/Common/Searchbox/ChatMessage/index.tsx | Removes chat message renderer. |
| apps/site/components/Common/Searchbox/ChatMessage/index.module.css | Removes chat message styles. |
| apps/site/components/Common/Searchbox/ChatInteractions/index.tsx | Removes chat interactions container. |
| apps/site/components/Common/Searchbox/ChatInteractions/index.module.css | Removes chat interactions styles. |
| .gitignore | Ignores generated apps/site/public/orama-db.json. |
| .github/workflows/sync-orama.yml | Removes workflow that synced Orama Cloud. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8836 +/- ##
==========================================
- Coverage 73.88% 73.18% -0.71%
==========================================
Files 105 102 -3
Lines 8889 8623 -266
Branches 326 314 -12
==========================================
- Hits 6568 6311 -257
+ Misses 2320 2311 -9
Partials 1 1 ☔ View full report in Codecov by Sentry. |
|
|
Perhaps I should GZip the file? |
|
I imagine you're going to want to chunk that file, GZiping would only be a temporary fix and would bite us again as the site grows. |
Wait, really? Interesting. We should probably document it now, can also be done in a follow-up PR if needed, @avivkeller! |
|
@avivkeller Not sure if you’re aware, but API docs results are redirecting to 404 pages |
|
@araujogui Yes, that's because they are on the preview URL, on the main site, that will not happen |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 67a346f. Configure here.
Understood! but it would be nice if this works on preview urls but I don't know how much complicated would be. |
|
@araujogui Better? |
cc @nodejs/web-infra
This PR changes our Orama implementation to use a locally-merged version of our API docs Orama and Learn Orama.