Merged
Conversation
Member
Author
|
Will probably need nodejs/node#29963 to pass |
Member
|
Any Collaborators wanting to speed this along: Go approve fast-tracking at nodejs/node#29963 (comment)! |
nschonni
force-pushed
the
chore--Expand-CI-test-globs
branch
2 times, most recently
from
764980f to
50b104a
Compare
XhmikosR
suggested changes
Oct 15, 2019
Contributor
XhmikosR
left a comment
XhmikosR
left a comment
There was a problem hiding this comment.
Please quote the globs with double quotes; this fails in some shells
Contributor
|
I wonder, can't we add a remark config file? It seems it'd be cleaner. |
Member
Author
|
I believe I tried that already, but their ignore system doesn't work properly with the CLI and causes failures still |
Contributor
|
NP, I guess we'll live with it :) Just make sure you double quote the globs. |
nschonni
force-pushed
the
chore--Expand-CI-test-globs
branch
from
50b104a to
0982091
Compare
Member
Author
|
Should just need the cleanups in nodejs/node#29982 now |
Member
Those cleanups landed, so re-running checks now. |
Member
Author
|
Thanks, looks like it's happy again |
Trott
approved these changes
Oct 15, 2019
XhmikosR
approved these changes
Oct 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Releated to #31
Doesn't include tools/doc or test