Skip to content

test: add cache testing#2623

Closed
tsctx wants to merge 13 commits intonodejs:mainfrom
tsctx:test/add-cache-test
Closed

test: add cache testing#2623
tsctx wants to merge 13 commits intonodejs:mainfrom
tsctx:test/add-cache-test

Conversation

@tsctx
Copy link
Copy Markdown
Member

@tsctx tsctx commented Jan 17, 2024

No description provided.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 17, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.28%. Comparing base (e39a632) to head (fc5398f).
⚠️ Report is 1542 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2623      +/-   ##
==========================================
+ Coverage   85.54%   87.28%   +1.73%     
==========================================
  Files          76       81       +5     
  Lines        6858     7293     +435     
==========================================
+ Hits         5867     6366     +499     
+ Misses        991      927      -64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown
Member

@KhafraDev KhafraDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure Every test here is already covered by WPTs. There is no reason to add these tests.

@tsctx
Copy link
Copy Markdown
Member Author

tsctx commented Jan 17, 2024

@KhafraDev #2612 (comment)

@KhafraDev
Copy link
Copy Markdown
Member

I think Matteo meant was that a test specifically for accessing the signal was needed, not that we need to duplicate the tests

@tsctx tsctx closed this Jan 17, 2024
@tsctx tsctx deleted the test/add-cache-test branch January 17, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants