-
Notifications
You must be signed in to change notification settings - Fork 304
chore: bump bb to 0.87.0 #8506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
chore: bump bb to 0.87.0 #8506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Compilation Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20
.
Benchmark suite | Current: 5ffe28e | Previous: d919e6a | Ratio |
---|---|---|---|
semaphore-depth-10 |
1.023 s |
0.843 s |
1.21 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
github-merge-queue bot
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
May 15, 2025
This PR fixes the issue in bb.js dependencies which is causing failures in noir-lang/noir#8506 This was broken in #13590 where the existing msgpack dependency was removed. Co-authored-by: AztecBot <[email protected]>
AztecBot
pushed a commit
to AztecProtocol/barretenberg
that referenced
this pull request
May 16, 2025
This PR fixes the issue in bb.js dependencies which is causing failures in noir-lang/noir#8506 This was broken in AztecProtocol/aztec-packages#13590 where the existing msgpack dependency was removed. Co-authored-by: AztecBot <[email protected]>
asterite
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
This PR bumps us up to a newer bb version to benefit from the crypto team's optimizations.
I've spoken to Lucas about the regressions (on empty circuits!) and it's expected and they're working on it.
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmt
on default settings.