Skip to content

fix: wrong npm doctor command result #1416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vanishcode wants to merge 3 commits into from
+109 −1
Closed

fix: wrong npm doctor command result #1416

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e0e7bd2
fix: wrong `npm doctor` command result
vanishcode Jun 10, 2020
80561ec
test: add test for `npm doctor` that ping registry returns error
vanishcode Jun 16, 2020
8cb9b8e
style: fix lint error with no trailing comma
vanishcode Jun 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/doctor/check-ping.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ function checkPing (cb) {
tracker.info('checkPing', 'Pinging registry')
ping({}, true, (err, pong) => {
if (err && err.code && err.code.match(/^E\d{3}$/)) {
return cb(null, [err.code.substr(1)])
return cb(null, [err.code.substr(1), 'failed'])
} else {
cb(null, [200, 'ok'])
}
Expand Down