Skip to content

fix: display multiple versions when --json on npm view#1657

Closed
claudiahdz wants to merge 2 commits intorelease/v7.0.0-betafrom
fix/npm-view
Closed

fix: display multiple versions when --json on npm view#1657
claudiahdz wants to merge 2 commits intorelease/v7.0.0-betafrom
fix/npm-view

Conversation

@claudiahdz
Copy link
Copy Markdown
Contributor

@claudiahdz claudiahdz commented Aug 11, 2020 •
edited
Loading

This PR fixes: #1640 and #1639

Some snapshots were regenerated since they contained some undefined and Object Object strings. Following Ruy's suggestion I removed npm-registry-mock and instead mocked directly pacote.

@claudiahdz claudiahdz added the Release 7.x work is associated with a specific npm 7 release label Aug 11, 2020
@claudiahdz claudiahdz requested a review from ruyadorno August 11, 2020 20:04
@claudiahdz claudiahdz requested a review from a team as a code owner August 11, 2020 20:04
@darcyclarke darcyclarke mentioned this pull request Aug 14, 2020
Closed
isaacs pushed a commit that referenced this pull request Aug 18, 2020
@claudiahdz @isaacs
fix: display multiple versions when --json on npm view
b718b0e 
PR-URL: #1657
Credit: @claudiahdz
Close: #1657
Reviewed-by: @isaacs
@ruyadorno ruyadorno closed this Aug 18, 2020
@nlf nlf deleted the fix/npm-view branch March 28, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ruyadorno ruyadorno ruyadorno approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Release 7.x work is associated with a specific npm 7 release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@claudiahdz @ruyadorno