This repository was archived by the owner on Aug 11, 2021. It is now read-only.
Ensure late errors on requests are passed through properly#148
Merged
Conversation
Contributor
|
LGTM. 🐑🚀🔥 I'd have to go spelunking in |
13 tasks
iarna
added a commit
to npm/npm
that referenced
this pull request
Dec 9, 2016
Fix a bug in fetch where errors on the request object that came after the response object had been emitted could result in duplicate callbacks and suppressed error conditions. Ultimately this translates to fixing shasum mismatches in `npm` when they were associated with an `ECONNRESET` or other network error. PR-URL: npm/npm-registry-client#139 Fixes: #14626 Credit: @iarna Add support for sending anonymous cli metrics. PR-URL: npm/npm-registry-client#148 Fix support for sending anonymous cli metrics. Credit: @sisidovski PR-URL: npm/npm-registry-client#147
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this patch, if an error is received on the
requestobject AFTERresponsehas been emitted then we retry the request without notifying the response that it failed.This makes it so that the error is passed along to the
responseobject and leaves any further retries as the responsibility of the caller.