feat(graph): enhance migration state management and introduce migration stopping functionality. #31626
+1,057
−633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndcunningham
requested review from
a team,
philipjfulcher,
FrozenPandaz,
bcabanes,
MaxKless and
xiongemi
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
View your CI Pipeline Execution ↗ for commit 6ac7d83.
☁️ Nx Cloud last updated this comment at |
…on stopping functionality. - Refactor guards to improve migration state checks and add conditions for running and completing migrations. - Update the state machine to handle new states for running, stopped, and evaluating migrations. - Implement logic to track running migrations and allow for stopping them gracefully. - Introduce a new process for running migrations in a separate child process to support cancellation. - Enhance metadata management to include stopped migrations and update UI accordingly. - Add tests to cover new migration states and behaviors, ensuring robust migration handling.
ndcunningham
force-pushed
the
feat/add-stop-cta-for-migrate-ui
branch
from
12278c6 to
f77e1a1
Compare
jaysoo
reviewed
Jun 17, 2025
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
jaysoo
reviewed
Jun 18, 2025
ndcunningham
force-pushed
the
feat/add-stop-cta-for-migrate-ui
branch
from
486b256 to
6ac7d83
Compare
jaysoo
approved these changes
Jun 19, 2025
FrozenPandaz
added
the
priority: medium
MaxKless
approved these changes
Jun 25, 2025
| ); | ||
|
|
||
| const currentMigrationFailed = useSelector(props.actor, (state) => | ||
| currentMigrationHasFailed(state.context) | ||
| const isCurrentMigrationStopped = useSelector( |
There was a problem hiding this comment.
nit but why does this one start with is... when the others don't?
| // Check if this migration is in the completed migrations | ||
| const completedMigration = | ||
| nxConsoleMetadata.completedMigrations?.[migration.id]; | ||
| const isSkipped = useSelector( |
There was a problem hiding this comment.
again, maybe we can find a way to reuse these selectors somehow?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR enhances the Migrate UI by adding a "Stop" button that allows users to halt in-progress migrations at any point during execution.
It works in tandem with nrwl/nx-console#2567
Currently
When a migration is running and needs to be stopped for any reason:
Users must wait for the migration to complete before using the available "Undo" or "Skip" options.
Expected
Users should be able to stop a currently running migration at any time before it completes, providing immediate control over the migration process.
Key Features: