fix(repo): add copy-assets plugin and migrate all packages from legacy-post-build by FrozenPandaz · Pull Request #34994 · nrwl/nx

FrozenPandaz · 2026-03-24T17:52:03Z

Current Behavior

Each package defines a legacy-post-build target in project.json with inline asset copy configuration. Inputs are not accurately declared, leading to sandbox violations in CI. The asset globs, ignores, and outputs must be manually kept in sync across 37 packages.

Expected Behavior

A copy-assets createNodesV2 plugin reads assets.json from each package and automatically generates the target with:

Inputs derived from asset globs (positive patterns first, then negations)
Outputs derived using the same dest logic as CopyAssetsHandler
dependentTasksOutputFiles for gitignored build artifacts (jars, native binaries)
Automatic outDir exclusion from asset copies

Changes

New infrastructure:

Add copy-assets createNodesV2 plugin in tools/workspace-plugin
Add copy-assets executor (simplified from legacy-post-build — just copies assets, no package.json field manipulation)
Extract normalizeAssets and getAssetOutputPath into reusable module in packages/js
Add copyReadme namedInput for copy-readme build targets

Migration (all 37 packages):

Create assets.json for every package defining what to copy
Remove all legacy-post-build targets from project.json files
Remove legacy-post-build target defaults from nx.json
Remove redundant copy-local-native target (replaced by .node/.wasm in asset glob)

Cleanup:

Remove dead config: creator-files globs, non-existent template files, typo'd directory names
Use root-level tsconfig*.json ignore instead of recursive (so template tsconfigs in files/ dirs are still copied)
Replace !(*.ts) extglob patterns with explicit globs (extglobs don't work correctly in Nx inputs)
Fix gradle lint: add buildTargets: ["build-base"] and tslib dependency
Add jar outputs to maven _package target for correct dependentTasksOutputFiles resolution

Other fixes:

Exclude .swc directories from sandbox write checks
Enable typecheck for angular-rspack packages (remove addTypecheckTarget: false)
Pin workspace-plugin deps to explicit versions, add @nx/plugin to root package.json

netlify · 2026-03-24T17:52:10Z

✅ Deploy Preview for nx-docs ready!

Name	Link
🔨 Latest commit	`90d2206`
🔍 Latest deploy log	https://app.netlify.com/projects/nx-docs/deploys/69c5b5a448bc100008d29bea
😎 Deploy Preview	https://deploy-preview-34994--nx-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify · 2026-03-24T17:52:10Z

✅ Deploy Preview for nx-dev ready!

Name	Link
🔨 Latest commit	`90d2206`
🔍 Latest deploy log	https://app.netlify.com/projects/nx-dev/deploys/69c5b5a42386c20008fe5191
😎 Deploy Preview	https://deploy-preview-34994--nx-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

nx-cloud · 2026-03-24T17:52:43Z

View your CI Pipeline Execution ↗ for commit 90d2206

Command	Status	Duration	Result
`nx affected --targets=lint,test,build,e2e,e2e-c...`	✅ Succeeded	45m 13s	View ↗
`nx run-many -t check-imports check-lock-files c...`	✅ Succeeded	7s	View ↗
`nx-cloud record -- pnpm nx conformance:check`	✅ Succeeded	7s	View ↗
`nx-cloud record -- nx format:check`	✅ Succeeded	3s	View ↗
`nx build workspace-plugin`	✅ Succeeded	<1s	View ↗
`nx-cloud record -- nx sync:check`	✅ Succeeded	<1s	View ↗
`nx affected -t e2e-macos-local --parallel=1 --b...`	✅ Succeeded	31m 51s	View ↗

☁️ Nx Cloud last updated this comment at 2026-03-26 23:28:44 UTC

graphite-app · 2026-03-26T03:59:02Z

+                ? [
+                    `${relative(projectRoot, assetsJson.outDir)}/**`,


The relative() call will fail when assetsJson.outDir is an absolute path. The code assumes assetsJson.outDir is always relative to projectRoot, but several assets.json files use absolute-style paths (e.g., packages/nx/dist, packages/dotnet/dist). When assetsJson.outDir doesn't start with projectRoot, relative() produces paths with .. segments that should not be in the ignore pattern.

const ignore = input === projectRoot && !path.isAbsolute(assetsJson.outDir) ? [ `${relative(projectRoot, assetsJson.outDir)}/**`, ...(asset.ignore ?? []), ] : asset.ignore;

Suggested change

? [

`${relative(projectRoot, assetsJson.outDir)}/**`,

input === projectRoot && !path.isAbsolute(assetsJson.outDir)

? [

`${relative(projectRoot, assetsJson.outDir)}/**`,

Spotted by Graphite

Is this helpful? React 👍 or 👎 to let us know.

graphite-app · 2026-03-26T15:45:05Z

+        const outputs = normalized.map((entry) => {
+          const outputPath = getAssetOutputPath(entry.pattern, entry);
+          if (outputPath.startsWith(projectRoot + '/')) {
+            return `{projectRoot}/${outputPath.slice(projectRoot.length + 1)}`;
+          }
+          return `{workspaceRoot}/${outputPath}`;
+        });


The getAssetOutputPath function is being called with entry.pattern (a glob pattern like packages/angular/**/files/**) but it expects an actual file path as its first argument. This will produce incorrect output patterns.

The function computes path.relative(entry.input, src) where src is expected to be a file path, not a glob pattern. For glob patterns, this will produce unpredictable results.

To fix, the outputs should be constructed directly from entry.output without trying to compute them from patterns:

const outputs = normalized.map((entry) => { if (entry.output.startsWith(projectRoot + '/')) { return `{projectRoot}/${entry.output.slice(projectRoot.length + 1)}/**`; } return `{workspaceRoot}/${entry.output}/**`; });

Suggested change

const outputs = normalized.map((entry) => {

const outputPath = getAssetOutputPath(entry.pattern, entry);

if (outputPath.startsWith(projectRoot + '/')) {

return `{projectRoot}/${outputPath.slice(projectRoot.length + 1)}`;

}

return `{workspaceRoot}/${outputPath}`;

});

const outputs = normalized.map((entry) => {

if (entry.output.startsWith(projectRoot + '/')) {

return `{projectRoot}/${entry.output.slice(projectRoot.length + 1)}/**`;

}

return `{workspaceRoot}/${entry.output}/**`;

});

Spotted by Graphite

Is this helpful? React 👍 or 👎 to let us know.

…puts Add outputs to maven-batch-runner _package target so dependentTasksOutputFiles can resolve the jar files. Narrow workspace-plugin input to just the executor files.

The !(*.ts) extglob doesn't work correctly in Nx inputs, causing .d.ts files to be excluded. Replace with explicit globs matching the standard pattern used by other packages.

Change **/tsconfig*.json to tsconfig*.json in asset ignores so template tsconfig files inside files/ directories are still copied.

Remove tsConfig, main, types, packageRoot, and addPackageJsonFields options. The executor now only needs assets and outputPath since the plugin always provides both.

…py-assets

The old legacy-post-build executor copied typings to types at build time. Now that the executor is simplified, set types directly in source package.json and remove the deprecated typings field.

…-specific cache Split .node files into separate asset entry with includeIgnoredFiles so they are tracked via dependentTasksOutputFiles. Add build-native to copy-assets dependsOn so the cache key includes the platform.

… [Self-Healing CI Rerun]

nx-cloud

Nx Cloud has identified a flaky task in your failed CI:

🔂 Since the failure was identified as flaky, we triggered a CI rerun by adding an empty commit to this branch.

View detailed reasoning in Nx Cloud ↗

🔔 Heads up, your workspace has pending recommendations ↗ to auto-apply fixes for similar failures.

_{🎓 Learn more about Self-Healing CI on nx.dev}

jaysoo · 2026-03-27T15:44:21Z

+  try {
+    await assetHandler.processAllAssetsOnce();
+  } catch (error) {
+    logger.error(`Error processing assets: ${error.message || error}`);


Nit: if error: unknown then you'd to check instanceof Error or that message is a property because using. We don't have strict mode on so it's passing typechecks.

## Current Behavior - The copy-assets plugin copies `assets.json` into the output directory (it doesn't exclude itself) - The copy-assets executor catches errors with `error.message` but `error` is typed as `unknown`, which can fail at runtime - No way to skip e2e cleanup when debugging locally ## Expected Behavior - `assets.json` is excluded from being copied into the output directory - Error handling properly checks `instanceof Error` before accessing `.message` - Setting `NX_E2E_SKIP_CLEANUP=true` preserves the test project directory for debugging ## Related Issue(s) Follow-up to #34994 — addresses review comments from that PR. --------- Co-authored-by: nx-cloud[bot] <71083854+nx-cloud[bot]@users.noreply.github.com>

github-actions · 2026-04-02T00:19:52Z

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

FrozenPandaz requested a review from a team as a code owner March 24, 2026 17:52

FrozenPandaz requested a review from MaxKless March 24, 2026 17:52

FrozenPandaz force-pushed the fix/sandboxing-config-native-node branch from 7eddc97 to fa911c7 Compare March 24, 2026 19:48

This comment was marked as outdated.

Sign in to view

FrozenPandaz force-pushed the fix/sandboxing-config-native-node branch 2 times, most recently from 776b85f to f3dd1c3 Compare March 25, 2026 14:35

This comment was marked as outdated.

Sign in to view

FrozenPandaz force-pushed the fix/sandboxing-config-native-node branch 4 times, most recently from c5db95e to e7c15ca Compare March 25, 2026 23:15

This comment was marked as outdated.

Sign in to view

graphite-app bot reviewed Mar 26, 2026

View reviewed changes

FrozenPandaz force-pushed the fix/sandboxing-config-native-node branch 4 times, most recently from a3a8def to 4571187 Compare March 26, 2026 14:55

FrozenPandaz changed the title ~~fix(repo): restore sandboxing config for native .node files~~ fix(repo): add copy-assets plugin and migrate all packages from legacy-post-build Mar 26, 2026

graphite-app bot reviewed Mar 26, 2026

View reviewed changes

This comment was marked as outdated.

Sign in to view

FrozenPandaz force-pushed the fix/sandboxing-config-native-node branch 5 times, most recently from c2e1ab8 to 8024262 Compare March 26, 2026 18:40

This comment was marked as outdated.

Sign in to view

FrozenPandaz added 13 commits March 26, 2026 16:06

fix(maven): add jar outputs to _package target and narrow executor in…

efb4520

…puts Add outputs to maven-batch-runner _package target so dependentTasksOutputFiles can resolve the jar files. Narrow workspace-plugin input to just the executor files.

fix(expo): add ignores to broad glob and remove redundant asset entries

dd6c5ef

fix(repo): replace extglob patterns with explicit asset globs

48458c4

The !(*.ts) extglob doesn't work correctly in Nx inputs, causing .d.ts files to be excluded. Replace with explicit globs matching the standard pattern used by other packages.

fix(repo): add missing md globs and fix gradle jar asset config

118e67a

fix(repo): use root-level tsconfig ignore instead of recursive

4b1d08a

Change **/tsconfig*.json to tsconfig*.json in asset ignores so template tsconfig files inside files/ directories are still copied.

chore(repo): rename legacy-post-build executor to copy-assets

679f3f4

cleanup(repo): simplify copy-assets executor by removing unused options

a412ed3

Remove tsConfig, main, types, packageRoot, and addPackageJsonFields options. The executor now only needs assets and outputPath since the plugin always provides both.

cleanup(repo): rename executor directory from legacy-post-build to co…

69f0051

…py-assets

fix(repo): use broad workspace-plugin glob for copy-assets inputs

b23e73e

fix(gradle): ignore batch-runner and project-graph dirs from json assets

2b21ada

fix(core): exclude __fixtures__ from nx js/node asset glob

a96db15

fix(repo): replace deprecated typings field with types in package.json

1876b11

The old legacy-post-build executor copied typings to types at build time. Now that the executor is simplified, set types directly in source package.json and remove the deprecated typings field.

FrozenPandaz force-pushed the fix/sandboxing-config-native-node branch from e164c3f to 8309fd7 Compare March 26, 2026 20:07

FrozenPandaz and others added 2 commits March 26, 2026 16:49

fix(repo): place types field in same position as former typings field

4dd0368

fix(repo): place types field in same position as former typings field…

124587c

… [Self-Healing CI Rerun]

This comment was marked as outdated.

Sign in to view

nx-cloud bot reviewed Mar 26, 2026

View reviewed changes

fix(repo): add type: commonjs to all published package.json files

90d2206

FrozenPandaz force-pushed the fix/sandboxing-config-native-node branch from b440466 to 90d2206 Compare March 26, 2026 22:39

jaysoo reviewed Mar 27, 2026

View reviewed changes

jaysoo approved these changes Mar 27, 2026

View reviewed changes

FrozenPandaz merged commit a040a93 into master Mar 27, 2026
25 checks passed

FrozenPandaz deleted the fix/sandboxing-config-native-node branch March 27, 2026 15:49

FrozenPandaz mentioned this pull request Mar 27, 2026

fix(repo): copy-assets plugin and e2e improvements #35042

Merged

github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2026

Conversation

FrozenPandaz commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current Behavior

Expected Behavior

Changes

Uh oh!

netlify bot commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for nx-docs ready!

Uh oh!

netlify bot commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for nx-dev ready!

Uh oh!

nx-cloud bot commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

graphite-app bot Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

graphite-app bot Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

nx-cloud bot left a comment

Choose a reason for hiding this comment

Nx Cloud has identified a flaky task in your failed CI:

Uh oh!

jaysoo Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Apr 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

FrozenPandaz commented Mar 24, 2026 •

edited

Loading

netlify bot commented Mar 24, 2026 •

edited

Loading

netlify bot commented Mar 24, 2026 •

edited

Loading

nx-cloud bot commented Mar 24, 2026 •

edited

Loading