fix(core): add run-native-target script input to dotnet build-analyzer#35221
Merged
FrozenPandaz merged 1 commit intomasterfrom Apr 9, 2026
Merged
fix(core): add run-native-target script input to dotnet build-analyzer#35221FrozenPandaz merged 1 commit intomasterfrom
FrozenPandaz merged 1 commit intomasterfrom
Conversation
✅ Deploy Preview for nx-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit 5b15da9
☁️ Nx Cloud last updated this comment at |
FrozenPandaz
approved these changes
Apr 9, 2026
FrozenPandaz
pushed a commit
that referenced
this pull request
Apr 9, 2026
#35221) ## Current Behavior The `dotnet:build-analyzer` target runs `node ./scripts/run-native-target.js _build-analyzer dotnet` but does not include the `run-native-target.js` script itself in its `inputs` array. This means changes to the script won't invalidate the Nx cache, potentially leading to stale cached results. ## Expected Behavior The `run-native-target.js` script is included as an input to the `build-analyzer` target, ensuring cache correctness when the script changes. ## Related Issue(s) Fixes NXC-4219 (cherry picked from commit 069ed82)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
The
dotnet:build-analyzertarget runsnode ./scripts/run-native-target.js _build-analyzer dotnetbut does not include therun-native-target.jsscript itself in itsinputsarray. This means changes to the script won't invalidate the Nx cache, potentially leading to stale cached results.Expected Behavior
The
run-native-target.jsscript is included as an input to thebuild-analyzertarget, ensuring cache correctness when the script changes.Related Issue(s)
Fixes NXC-4219