-
Notifications
You must be signed in to change notification settings - Fork 13
[WIP] Generate shared secret test vectors #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
+ Update some versions at cargo
description: String, | ||
shared_secret: Vec<u8>, | ||
plaintext: Option<String>, | ||
fixed_nonce: Option<Vec<u8>>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be annotated with #[serde(with = "serde_bytes::as_hex")]
similarly to bytestring fields in the main code, this way the test vectors will look a little tidier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, just FYI, the umbral_pre::serde_bytes
(that I wrote back in the day) has since been extracted into https://docs.rs/serde-encoded-bytes
1efbb84
to
3853f75
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #102 +/- ##
==========================================
+ Coverage 23.42% 23.66% +0.23%
==========================================
Files 18 18
Lines 3475 3436 -39
==========================================
- Hits 814 813 -1
+ Misses 2661 2623 -38 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e9b905f
to
2b73a71
Compare
+ in addtion to some refactorying + update README file
2b73a71
to
9771e18
Compare
Type of PR:
Required reviews:
What this does:
As part of: nucypher/taco-web#635, implement tests that generate shared secrets encrypt/decrypt values to check the TS implementation agains them.
Also README.md file has been updated.
Issues fixed/closed:
Notes for reviewers: