Skip to content

feat: refine type for CollectionQueryBuilder.first() method #3265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 19, 2025

Conversation

MellKam
Copy link
Contributor

@MellKam MellKam commented Mar 19, 2025

πŸ”— Linked issue

resolves #3264

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

pkg-pr-new bot commented Mar 19, 2025

npm i https://pkg.pr.new/@nuxt/content@3265

commit: 867eb7c

@MellKam
Copy link
Contributor Author

MellKam commented Mar 19, 2025

I tried running test:types script, but it fails with numerous errors unrelated to this PR.

Found 95 errors in 23 files.
   3  ../src/runtime/app.ts:19
     2  ../src/runtime/internal/api.ts:9
     6  ../src/runtime/internal/database.client.ts:16
    13  ../src/runtime/internal/database.server.ts:10
     1  ../src/runtime/internal/navigation.ts:103
     2  ../src/runtime/internal/query.ts:133
     2  ../src/runtime/internal/search.ts:5
     1  ../src/runtime/internal/surround.ts:3
     2  ../src/runtime/nitro.ts: on type '{ hackernews: string; content: string; data: string; p

"strictNullChecks": false,

If you enable strictNullChecks, you will see even more errors. I’m not sure why this option was disabled, as it allows for a lot of potential issues.

Copy link
Member

@farnabaz farnabaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks πŸ‘

@farnabaz farnabaz merged commit 8c2afa5 into nuxt:main Mar 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refine type for CollectionQueryBuider first() method
2 participants