Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #18016
Summary of the issue:
When braille Word wrap is enabled, NVDA doesn't check if the first character of the next braille window is a space, causing that in some cases NVDA Splits text between braille Windows instead of using all braille cells.
Description of user facing changes:
When possible, all braille cells Will be used even if word wrap option is enabled.
Description of developer facing changes:
None.
Description of development approach:
In
source/braille.py
, the_calculateWindowRowBufferOffsets()
function has been modified to check if the next character is a space when Word wrap is True, so that all cells can be used in such cases.Testing strategy:
In Notepad, type:
Use a Focus 40 braille display to check that all cells are used, when Word wrap is enabled and disabled.
Known issues with pull request:
None.
Code Review Checklist:
@coderabbitai summary