Skip to content

Highlight Overhaul #2415

Closed
Closed
@alex-courtis

Description

@alex-courtis

#2410 demonstrated that highlighting can be additive e.g. add underline with a different colour.

There are some inconsistencies in how highlighting is applied e.g. highlight_opened_files vs highlight_git

  • Make all highlights additive as per feat(#1079): add renderer.highlight_clipboard default name, default undercurls #2410
    • git
    • diagnostics
    • opened
    • modified
    • bookmarks
    • clipboard
  • Make all highlights granular "none", "icon", "name", "all"
    • highlight_git
    • highlight_diagnostics
    • highlight_opened_files
    • highlight_modified
    • highlight_bookmarks
    • highlight_clipboard
  • Refactor highlight groups to be consistent and end with HL and Icon
    • git
    • diagnostics
    • opened
    • modified
    • bookmarks
    • clipboard
  • clean up and standardise get_colours
  • cterm compatibility
  • investigate term compatibility (e.g. linux) - colours and highlights are distinct and readable, just missing icons
  • legacy highlight group linking
  • simplify renderer builder for efficiency

Refactor may be silently done as per options.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions