Skip to content

Commit 6ac83b9

Browse files
authored
Just build from the latest version (#117)
* remove kubectl version publishes * remove GCLOUD_SDK_TAG arg * update readme * add codeowners * keep GCLOUD_SDK_TAG in dockerfile * set default tag * fix paren
1 parent 88679fc commit 6ac83b9

File tree

4 files changed

+21
-29
lines changed

4 files changed

+21
-29
lines changed

.drone.yml

Lines changed: 4 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -45,39 +45,20 @@ pipeline:
4545

4646
publish_develop:
4747
<<: *publish_config
48-
build_args:
49-
- GCLOUD_SDK_TAG=alpine
50-
tag:
48+
tags:
5149
- "develop"
5250
when:
5351
event: push
5452
branch: develop
5553

56-
publish_latest:
54+
publish_release:
5755
<<: *publish_config
58-
build_args:
59-
- GCLOUD_SDK_TAG=alpine
6056
auto_tag: true
6157

62-
publish_1_10:
63-
<<: *publish_config
64-
build_args:
65-
- GCLOUD_SDK_TAG=217.0.0-alpine
66-
auto_tag: true
67-
auto_tag_suffix: "k8s-1.10"
68-
69-
publish_1_11:
70-
<<: *publish_config
71-
build_args:
72-
- GCLOUD_SDK_TAG=241.0.0-alpine
73-
auto_tag: true
74-
auto_tag_suffix: "k8s-1.11"
75-
7658
slack:
7759
image: plugins/slack
7860
channel: dv-notifications
79-
secrets:
80-
- slack_webhook
61+
secrets: [slack_webhook]
8162
when:
8263
branch:
8364
- develop
@@ -86,8 +67,7 @@ pipeline:
8667
slack_tag:
8768
image: plugins/slack
8869
channel: dv-notifications
89-
secrets:
90-
- slack_webhook
70+
secrets: [slack_webhook]
9171
when:
9272
event:
9373
- tag

CODEOWNERS

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
# These owners will be the default owners for everything in the repo.
2+
# Unless a later match takes precedence, these owners
3+
# will be requested for review when someone opens a pull request.
4+
* @nytm/delivery-engineering

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# see https://hub.docker.com/r/google/cloud-sdk/tags for available tags / versions
2-
ARG GCLOUD_SDK_TAG
2+
ARG GCLOUD_SDK_TAG=alpine
33

44
FROM google/cloud-sdk:${GCLOUD_SDK_TAG}
55

README.md

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,19 +17,27 @@ Derive the API endpoints and credentials from the Google credentials and open th
1717

1818
### Tool
1919

20+
This tool follows [semantic versioning](https://semver.org/).
21+
2022
Use the `x.X` releases for stable use cases (eg 0.8).
2123
Breaking changes may occur between `x.X` releases (eg 0.7 and 0.8), and will be documented in the [release notes](https://github.com/nytimes/drone-gke/releases).
2224

2325
### Kubernetes API
2426

25-
Use the release [tag](https://hub.docker.com/r/nytimes/drone-gke/tags/) suffixed with your desired `kubectl` version.
26-
The last two-three minor releases are supported ([same as GKE](https://cloud.google.com/kubernetes-engine/versioning-and-upgrades)).
27+
Since the [237.0.0 (2019-03-05) Google Cloud SDK][sdk], the container image contains multiple versions of `kubectl`.
28+
The corresponding client version that matches the cluster version will be used automatically.
29+
This follows the minor release support that [GKE offers](https://cloud.google.com/kubernetes-engine/versioning-and-upgrades).
30+
31+
If you want to use a different version, you can specify the version of `kubectl` used with the [`kubectl_version` parameter][version-parameter].
32+
33+
[sdk]: https://cloud.google.com/sdk/docs/release-notes#23700_2019-03-05
34+
[version-parameter]: DOCS.md#kubectl_version
2735

2836
### Container
2937

3038
- Pushes to the [`develop`](https://github.com/nytimes/drone-gke/tree/develop) branch will update the image tagged `develop`.
31-
- Pushes to the [`master`](https://github.com/nytimes/drone-gke/tree/master) branch will update the images tagged `latest` and corresponding `kubectl` versions.
32-
- Tags to the [`master`](https://github.com/nytimes/drone-gke/tree/master) branch will create the images with the tag value (eg `0.7.1` and `0.7`) and corresponding `kubectl` versions.
39+
- Pushes to the [`master`](https://github.com/nytimes/drone-gke/tree/master) branch will update the image tagged `latest`.
40+
- Tags to the [`master`](https://github.com/nytimes/drone-gke/tree/master) branch will create the images with the patch and minor tag values (eg `0.7.1` and `0.7`).
3341

3442
## Usage
3543

0 commit comments

Comments
 (0)