Just build from the latest version #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montmanu
approved these changes
Aug 21, 2019
Contributor
There was a problem hiding this comment.
LGTM, though I wonder whether we might prefer to preserve the flexibility enabled by the build arg .. ?
In other words, we could just remove the publish_${major}_${minor} drone steps and leave the GCLOUD_SDK_TAG build arg implementation unchanged.. Seems that would achieve the objective of this PR (always building / publishing from latest upstream alpine) without impacting our ability to easily build (and publish) from other base images.. some example uses cases:
- programmatically build multiple versions locally to aid with the debugging / testing of upstream releases
- build / publish a
drone-gke:slimvariant from the upstream'sslimvariant that selectively preinstalls additional components (via it'sINSTALL_COMPONENTSbuild arg) for user's with non-alpine requirements - build / publish a
drone-gke:debugvariant from the upstream'slatestvariant to include the kitchen sink of preinstalled components (e.g., for experimenting w/krewplugins that interact with non-gke APIs) - etc..
i don't feel too strongly either way, just figured i'd mention it!
Member
Author
|
Sounds good, kept that in. |
mlclmj
reviewed
Aug 23, 2019
README.md
Outdated
| The last two-three minor releases are supported ([same as GKE](https://cloud.google.com/kubernetes-engine/versioning-and-upgrades)). | ||
| Since the [237.0.0 (2019-03-05) Google Cloud SDK][sdk], the container image contains multiple versions of `kubectl`. | ||
| The corresponding client version that matches the cluster version will be used automatically. | ||
| This follows the minor release support that ([GKE offers](https://cloud.google.com/kubernetes-engine/versioning-and-upgrades)). |
Member
There was a problem hiding this comment.
are the parentheses around GKE offers intentional?
mlclmj
approved these changes
Aug 23, 2019
mlclmj
approved these changes
Aug 23, 2019
Member
|
whoops sorry about the double approve |
montmanu
approved these changes
Aug 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to specify which version of the SDK since the original intent was to support multiple
kubectlversions at the same time (see #90).Thought about this as I was preparing to tag a release.