Skip to content

Updated to work with the latest embedded-io-async from embassy #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

TinHead
Copy link

@TinHead TinHead commented Oct 19, 2023

Hi,

Embassy-rs updated from using embadded-io::asynch to embedded-io-async, so using rust-mqtt with it would now fail.
@shulltronics updated his fork to use the new(er?) embedded-io-async ( thanks! ), I just updated it to use 0.6.0.

It compiles for me hope nothing else broke tested with my code here:
https://github.com/TinHead/embassy-playground/tree/main/wifi-gw

Cheers,
TH

Copy link
Collaborator

@lulf lulf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from the defmt feature

@@ -16,6 +16,7 @@ rand_core = "0.6.0"
defmt = { version = "0.3", optional = true }
log = { version = "0.4.14", optional = true }
embedded-io = { version = "0.4.0", features = ["async"]}
embedded-io-async = { version = "0.6.0", features = ["defmt-03"]}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest not using defmt-03 by default.

Copy link
Author

@TinHead TinHead Oct 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently that's how the defmt feature is called :)
https://github.com/rust-embedded/embedded-hal/tree/master/embedded-io-async

I won't compile without it:
cargo build error: failed to select a version for embedded-io-async. ... required by package rust-mqtt v0.1.5 (/home/razvan/work/embassy-playground/rust-mqtt)versions that meet the requirements^0.6.0` (locked to 0.6.0) are: 0.6.0

the package rust-mqtt depends on embedded-io-async, with features: defmt but embedded-io-async does not have these features.

failed to select a version for embedded-io-async which could resolve this conflict`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems they want the defmt version to be specified in the features rather than automatically using the latest version to improve stability. See this comment: rust-embedded/embedded-hal#483 (comment)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lulf Is this resolved ?

@TinHead TinHead changed the title Updated to work with the latest embadded-io-async from embassy Updated to work with the latest embedded-io-async from embassy Oct 20, 2023
@TinHead
Copy link
Author

TinHead commented Oct 30, 2023

no further feedback ... closing

@TinHead TinHead closed this Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants