Skip to content

quick fix for node roles in ES5 #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2016
Merged

quick fix for node roles in ES5 #14

merged 1 commit into from
Nov 9, 2016

Conversation

evanfreed
Copy link
Contributor

It's sort of a hacky fix but resolves #13. Would like to clean this up at a later time.

jtharpla
jtharpla approved these changes Nov 8, 2016
View reviewed changes
Copy link
Contributor

@jtharpla jtharpla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing that...the whole approach I used for get_role is pretty messy with the pre 2.3.x roles versus the newer format, so I wouldn't beat yourself up over a bit of spakling here.

@evanfreed evanfreed merged commit a3144d6 into master Nov 9, 2016
@evanfreed evanfreed deleted the es_5_fixes branch November 9, 2016 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtharpla jtharpla jtharpla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Roles for ES5
2 participants
@evanfreed @jtharpla