Skip to content

Expose OBOT_BASE_URL as global flag in CLI help #5264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 5 commits into
base: main
Choose a base branch
from
+8 −4
Draft

Expose OBOT_BASE_URL as global flag in CLI help #5264

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
57c130c
Initial plan
Copilot Dec 10, 2025
073765f
Expose OBOT_BASE_URL as global flag in CLI help
Copilot Dec 10, 2025
b4f557b
Simplify BaseURL assignment in PersistentPre
Copilot Dec 10, 2025
357a8e1
Remove redundant BaseURL initialization in Client struct
Copilot Dec 10, 2025
c59583e
Inline baseURL variable initialization
Copilot Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions pkg/cli/root.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,9 @@ import (
)

type Obot struct {
Debug bool `usage:"Enable debug logging"`
Client *apiclient.Client
Debug bool `usage:"Enable debug logging"`
BaseURL string `usage:"Base URL for the OBOT API" default:"http://localhost:8080/api"`
Copy link
Contributor

@cjellick cjellick Dec 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you have to move BaseURL onto this struct rather than just leveraging the one thats already on Client?

Client *apiclient.Client
}

func (a *Obot) PersistentPre(*cobra.Command, []string) error {
Expand All @@ -27,6 +28,9 @@ func (a *Obot) PersistentPre(*cobra.Command, []string) error {
logger.SetDebug()
}

// Update the client's BaseURL from the flag/env value
a.Client.BaseURL = a.BaseURL

if a.Client.Token == "" {
a.Client = a.Client.WithTokenFetcher(internal.Token)
}
Expand All @@ -36,9 +40,9 @@ func (a *Obot) PersistentPre(*cobra.Command, []string) error {

func New() *cobra.Command {
root := &Obot{
BaseURL: env.VarOrDefault("OBOT_BASE_URL", "http://localhost:8080/api"),
Client: &apiclient.Client{
BaseURL: env.VarOrDefault("OBOT_BASE_URL", "http://localhost:8080/api"),
Token: os.Getenv("OBOT_TOKEN"),
Token: os.Getenv("OBOT_TOKEN"),
},
}
return cmd.Command(root,
Expand Down