feat: add ACR-specific registry endpoints #5299
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grant Linville <[email protected]>
Signed-off-by: Grant Linville <[email protected]>
g-linville
force-pushed
the
registry-per-acr-2
branch
from
500933e to
cfce217
Compare
thedadams
reviewed
Dec 22, 2025
| rw.Header().Set("WWW-Authenticate", fmt.Sprintf(`Bearer realm="MCP Registry", resource_metadata="%s/.well-known/oauth-protected-resource/v0.1/servers"`, strings.TrimSuffix(s.baseURL, "/api"))) | ||
| if !s.registryNoAuth { | ||
| if strings.HasPrefix(req.URL.Path, "/v0.1") { | ||
| rw.Header().Set("WWW-Authenticate", fmt.Sprintf(`Bearer realm="MCP Registry", resource_metadata="%s/.well-known/oauth-protected-resource/v0.1/servers"`, strings.TrimSuffix(s.baseURL, "/api"))) |
Contributor
There was a problem hiding this comment.
nit: I don't think the s.baseURL has /api appended to it, so we don't need to TrimSuffix here (and below).
| } | ||
| server, err := h.fetchCatalogEntry(req, resource.ID, catalogID, workspaceID, reverseDNS) | ||
| if err != nil { | ||
| // Skip entries that can't be fetched |
Contributor
There was a problem hiding this comment.
I would like to see us log any errors we are ignoring during this process.
|
|
||
| revealed, err := req.GPTClient.RevealCredential(req.Context(), []string{ctx}, server.Name) | ||
| if err != nil { | ||
| return make(map[string]string), nil |
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| return make(map[string]string), nil | |
| return nil, nil |
| } | ||
|
|
||
| // authGroupSet extracts auth groups from user info (reuse from helper.go) | ||
| func authGroupSet(user interface{ GetExtra() map[string][]string }) map[string]struct{} { |
Contributor
There was a problem hiding this comment.
Is there a reason the type of user can't be the user.Info?
Member
Author
|
I'm (perhaps temporarily) abandoning this PR since we are now unsure about whether we still want this feature |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new MCP Registry API setup for each individual AccessControlRule.
I don't believe there is a GH issue that corresponds to this.