Skip to content

🐛 Update category remapping logic to work with immutable categories#1234

Merged
fcakyon merged 7 commits intoobss:mainfrom
gboeer:main
Aug 26, 2025
Merged

🐛 Update category remapping logic to work with immutable categories#1234
fcakyon merged 7 commits intoobss:mainfrom
gboeer:main

Conversation

@gboeer
Copy link
Copy Markdown
Contributor

@gboeer gboeer commented Aug 22, 2025

The label remapping logic didn't work with the introduced immutable categories, now it does.
Also added a test for the remapping.

Discussed in:
#1231

@fcakyon fcakyon requested a review from onuralpszr August 22, 2025 10:47
@onuralpszr
Copy link
Copy Markdown
Collaborator

@gboeer I will read issue and check PR as soon as possible

@fcakyon
Copy link
Copy Markdown
Collaborator

fcakyon commented Aug 23, 2025

@gboeer thanks a lot for coming up with a fast fix for the discussed issue! 🚀

I am unable to pull the latest updates from the sahi main branch to your main branch because your fork's main branch only accepts signed commits 🤔

Can you please disable your main branch protection rule or open this PR from another branch?

@fcakyon fcakyon added bug Something isn't working enhancement New feature or request labels Aug 23, 2025
@gboeer
Copy link
Copy Markdown
Contributor Author

gboeer commented Aug 25, 2025

Oh yeah i accidentally forgot to create the PR from a feature branch. I've updated my main, can you merge now?

@fcakyon fcakyon merged commit 039833b into obss:main Aug 26, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants