Skip to content

Add evm feature to NuFi #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

PeterBenc
Copy link

NuFi now supports EVM, sorry for the branch name I did this in Github, I am not sure I had some control over that

@PeterBenc PeterBenc requested a review from a team as a code owner February 6, 2025 13:52
Copy link

vercel bot commented Feb 6, 2025

@PeterBenc is attempting to deploy a commit to the Flow Team on Vercel.

A member of the Team first needs to authorize it.

@jribbink
Copy link
Contributor

jribbink commented Feb 14, 2025

Hey Peter, thanks for the PR and the team’s interest in exploring integrations with Flow EVM! Sorry that I didn’t respond earlier, I’ve just now noticed this.

The original intention of the “EVM” tag here was to categorize any Cadence wallets with built-in support for interacting with the user’s Cadence Owned Account (COA).

In essence, COAs are the composability bridge between Cadence and Flow EVM allowing user’s assets to seamlessly transition between Cadence <-> EVM environments.

Traditional Externally Owned Accounts (EOAs) do not share the same user guarantees as their EOA counterpart. There is no linking between the user’s Cadence & EVM accounts as in the COA model. Users must manually transfer assets from their EOA to interact with them from the Cadence VM.

You’ve definitely highlighted a weakness of our current categorization in FCL Discovery, however. NuFi fit’s the strict definition of “Flow EVM compatible” and I definitely wouldn’t want to unintentionally undermine the project’s branding.

I’m happy to work together on revising these categories so they more appropriately reflect each wallet's offerings or how NuFi could benefit from surfacing COAs to their users.

@PeterBenc
Copy link
Author

Hi @jribbink, thanks for the response. NuFis approach to to COAs is slightly different than FlowWallet, but I would argue that it achieves whatever FlowWallet does so it deserves the EVM badge. Let me know what you think.

In NuFi, we have generic support for any EVM chain, so yes, we also have FlowEVM - EOAs.

But we also have a model for COAs. We combine user's balance on FlowVM and COA into one account. We allow users to

  • receive funds on COA address
  • send these funds (FTs & NFTs), to either Flow address or EVM, using the assets from both FlowVM and COA in one transaction, based on how what and how much is required.

From the user's perspective, the only thing that changed is that he sees a COA address, as an option when trying to receive on Flow and he can natively bridge between Flow and FlowEvm just by sending.

I would argue that the above meets the description of

allowing user’s assets to seamlessly transition between Cadence <-> EVM environments

What do you think?

@jribbink
Copy link
Contributor

Hi @jribbink, thanks for the response. NuFis approach to to COAs is slightly different than FlowWallet, but I would argue that it achieves whatever FlowWallet does so it deserves the EVM badge. Let me know what you think.

In NuFi, we have generic support for any EVM chain, so yes, we also have FlowEVM - EOAs.

But we also have a model for COAs. We combine user's balance on FlowVM and COA into one account. We allow users to

  • receive funds on COA address
  • send these funds (FTs & NFTs), to either Flow address or EVM, using the assets from both FlowVM and COA in one transaction, based on how what and how much is required.

From the user's perspective, the only thing that changed is that he sees a COA address, as an option when trying to receive on Flow and he can natively bridge between Flow and FlowEvm just by sending.

I would argue that the above meets the description of

allowing user’s assets to seamlessly transition between Cadence <-> EVM environments

What do you think?

I totally understand the branding aspects where you want to accurately represent NuFi's feature set and I do agree that this implies NuFi is not EVM-compatible, which would be a misnomer.

I want to see how we can come to some sort of compromise here and potentially explore how we can adjust these labels to better represent the capabilities of each wallet.

I wanted to check out the Flow EVM support in NuFi myself so I could better understand the product offerings to further our discussions, however I wasn't able to see my Flow EVM account in the wallet. This account owns a COA with a >0 FLOW balance in EVM.

Screenshot 2025-03-13 at 4 28 45 PM

Please let me know if I did something incorrectly or whether this is a supported feature.

@PeterBenc
Copy link
Author

PeterBenc commented Apr 17, 2025

@jribbink sorry for the late reply.

however I wasn't able to see my Flow EVM account in the wallet

Any balance that is on Flow EVM account (I guess you mean COA) is combined with the balance on the FlowVM. So the amount you see is the combination of the FlowVm and COA of that account. I just tried and confimed this works.

Other than that, what I wrote here applies #278 (comment)

Btw, if we cannot resolve this here I am ok with quick call in which I can showcase what nufi does.


Note: right now our tx history is a bit off, because of the changes in the flowscan api, so ignore that, should be fixed next week.

@jribbink
Copy link
Contributor

@jribbink sorry for the late reply.

however I wasn't able to see my Flow EVM account in the wallet

Any balance that is on Flow EVM account (I guess you mean COA) is combined with the balance on the FlowVM. So the amount you see is the combination of the FlowVm and COA of that account. I just tried and confimed this works.

Other than that, what I wrote here applies #278 (comment)

Btw, if we cannot resolve this here I am ok with quick call in which I can showcase what nufi does.

Note: right now our tx history is a bit off, because of the changes in the flowscan api, so ignore that, should be fixed next week.

Yeah I think it would be great to setup a call, I've just sent a friend request on Discord so we can setup a time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants