refactor: Port measurement overlay to React #1411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Co-Authored-By: [email protected] <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Kitenite
reviewed
Feb 18, 2025
| @@ -122,7 +122,7 @@ export const MeasurementOverlay: React.FC<MeasurementProps> = memo(({ fromRect, | |||
| const result: Distance[] = []; | |||
|
|
|||
| // Scale values for display | |||
| const scaleValue = (value: number) => adaptValueToCanvas(Math.abs(value)); | |||
| const scaleValue = (value: number) => adaptValueToCanvas(Math.abs(value), true); | |||
There was a problem hiding this comment.
wtf it was just this? Thanks for spotting!
ml-delaurier
pushed a commit
to ml-delaurier/nolook
that referenced
this pull request
Apr 23, 2025
* refactor: Port measurement overlay to React * fix: scale measurement values with webview transform * fix: overlay scale * refactor: remove deprecated measurement --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: vutnguyen <[email protected]>
t1c1
pushed a commit
to t1c1/onlookbotcodes
that referenced
this pull request
Jun 5, 2025
* refactor: Port measurement overlay to React * fix: scale measurement values with webview transform * fix: overlay scale * refactor: remove deprecated measurement --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: vutnguyen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restores the alt to measure behavior using React components.
Fixes #958
Link to Devin run: https://app.devin.ai/sessions/c1f09821f9c745028487d72f99b4b67c